Add some more sanity-type tests, including perl critic

RESOLVED FIXED

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
As more people contribute to BMO on a one-off or infrequent basis, it becomes more important to check for common errors.

A lot of errors can be found by perl critic -- and perl critic can be used by the very user-friendly Visual Studio Code editor -- which means that pretty much anyone could make use of it.

So in this bug I'm adding a perlcriticrc file and a test that checks the code against it. Of course, even with a lot of tweaks the code still has perl critic errors -- but the test doesn't care about errors that already exist. It only cares that the number of errors doesn't grow.

Meanwhile, while writing this I realized I had sloppily added dependencies to cpanfile in the bmo-systems repo -- so I've properly added that (Test::Selenium::Firefox) to the Makefile.PL.

Finally, we pin the version of bmo-slim (our base docker container) in both Dockerfile and the circle ci config. I added a simple test that will detect if those are ever in disagreement.
Posted file github pull request
Attachment #8911833 - Flags: review?(dkl)
Attachment #8911833 - Flags: review?(dkl) → review+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.