1402928 - log information about server side release merging attempts

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

While working on https://github.com/mozilla/balrog/pull/409#issuecomment-331936859, I discovered that server side Release merging was not happening in the vast majority of update race cases. The only reason I found this out was because I was looking at DEBUG-level logs on a dev server.

It would be great if we could log information about attempted, successful, and failed data race resolutions, and have them show up on Datadog.

It's probably worthwhile doing some WARNING messages whenever a race fails, too, since that's what we log at in production. It would give a shot at debugging live issues.

Comment 1

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #0)
> It would be great if we could log information about attempted, successful,
> and failed data race resolutions, and have them show up on Datadog.

Relud, I think I was told a long time ago that if we log with statsd, things would automatically be available in Datadog. Is that true? If not, is there a way we can log stuff to be available there?

Comment 2

[Daniel Thorn [:relud]]

that is correct. that said, don't create more than say, 50 metrics without consulting me. you can also use the dogstatsd library to add tags to your statsd metrics. if you do that, every combination of tags counts as a different metric for the purpose of that arbitrary 50 metric threshold.

Comment 3

[Daniel Thorn [:relud]]

if you want full logging information, i suggest logging in mozlog format and i can get you set up to query that from redash.

Comment 4

[[e-mail] (:bhearsum)]

We're burning this down soon, no need to fix this. See https://github.com/mozilla-releng/balrog/issues/1049