1402955 - bouncer submission failed for firefox 57.0b3

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Kim Moir [:kmoir] ET]

I think this is because of an extra bracket here before "partials": 

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-noarch/release-mozilla-beta_firefox_bncr_sub-bm72-build1-build28.txt.gz

diff --git a/testing/mozharness/configs/releases/bouncer_firefox_beta.py b/testing/mozharness/configs/releases/bouncer_firefox_beta.py
--- a/testing/mozharness/configs/releases/bouncer_firefox_beta.py
+++ b/testing/mozharness/configs/releases/bouncer_firefox_beta.py
@@ -100,44 +100,16 @@ config = {
                     "bouncer-platform": "win",
                 },
                 "win64": {
                     "path": "/firefox/releases/%(version)s/update/win64/:lang/firefox-%(version)s.complete.mar",
                     "bouncer-platform": "win64",
                 },
             },
         },
-        "complete-mar-bz2": {
-            "product-name": "Firefox-%(version)s-Complete-bz2",
-            "check_uptake": True,
-            "ssl-only": False,
-            "add-locales": True,
-            "paths": {
-                "linux": {
-                    "path": "/firefox/releases/%(version)s/update/linux-i686/:lang/firefox-%(version)s.bz2.complete.mar",
-                    "bouncer-platform": "linux",
-                },
-                "linux64": {
-                    "path": "/firefox/releases/%(version)s/update/linux-x86_64/:lang/firefox-%(version)s.bz2.complete.mar",
-                    "bouncer-platform": "linux64",
-                },
-                "macosx64": {
-                    "path": "/firefox/releases/%(version)s/update/mac/:lang/firefox-%(version)s.bz2.complete.mar",
-                    "bouncer-platform": "osx",
-                },
-                "win32": {
-                    "path": "/firefox/releases/%(version)s/update/win32/:lang/firefox-%(version)s.bz2.complete.mar",
-                    "bouncer-platform": "win",
-                },
-                "win64": {
-                    "path": "/firefox/releases/%(version)s/update/win64/:lang/firefox-%(version)s.bz2.complete.mar",
-                    "bouncer-platform": "win64",
-                },
-            },
-        },
     },
     },
     "partials": {
         "releases-dir": {
             "product-name": "Firefox-%(version)s-Partial-%(prev_version)s",
             "check_uptake": True,
             "ssl-only": False,

Comment 1

[Kim Moir [:kmoir] ET]

missed this in the first comment

hg diff -r 55d0a2aa99de -r 69932f66faf2 testing/mozharness/configs/releases/bouncer_firefox_beta.py

Rail, should we land a patch for this and run a build from a new revision or should we run the bouncer submission manually?

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Kim Moir [:kmoir] ET from comment #1)
> missed this in the first comment
> 
> hg diff -r 55d0a2aa99de -r 69932f66faf2
> testing/mozharness/configs/releases/bouncer_firefox_beta.py
> 
> Rail, should we land a patch for this and run a build from a new revision or
> should we run the bouncer submission manually?

Do you mean land a tree patch and wait for the builds to run or specify just the Mozharness Revision with the fix and keep the current revision? If latter, this doesn't always work, it's more of a dice roll. 

Another solution could be to hack releasetasks to only send a graph with just one task - the bouncer submission. I did something like that for Fennec once.

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug1402955.patch

Comment 4

[Kim Moir [:kmoir] ET]

•nthomas> last time we hit a syntax error r.ail landed the fix, cloned the task and updated it to use the new rev. No downstream tasks so this works fin

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8911970 [details] [diff] [review]
bug1402955.patch

Oops, my bad. I'm going to land it, uplift and fix the current build. Sorry for the churn.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a172badf4ab6
Fix bouncer_firefox_beta.py syntax. r=rail DONTBUILD

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8911970 [details] [diff] [review]
bug1402955.patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/a172badf4ab6451346c22c982034da6bca9c5c67
https://hg.mozilla.org/releases/mozilla-beta/rev/7d7a99abed83d38d0efe50aa657ca88b0473b8e2

Comment 8

[Rail Aliiev [:rail]]

I cloned https://tools.taskcluster.net/task-inspector/#e9HcqXt-QaOL2VzeXuTUzQ, replaced all revisions with 7d7a99abed83d38d0efe50aa657ca88b0473b8e2 and started it as https://tools.taskcluster.net/groups/dbOabQh1QOWSbkCT6rZOVA/tasks/dbOabQh1QOWSbkCT6rZOVA/details

Comment 9

[Rail Aliiev [:rail]]

I did the same for ZPZz9WCHQr6qUXHve4TMLg. After the cloned task became green, I rerun the original task and resolved it asap:

taskcluster-cli task rerun ZPZz9WCHQr6qUXHve4TMLg && taskcluster-cli task complete ZPZz9WCHQr6qUXHve4TMLg

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a172badf4ab6

Comment 11

[Rail Aliiev [:rail]]

Did similar thing for bouncer aliases in https://tools.taskcluster.net/groups/GmRau2v0TXmDi0j_wwXSWQ/tasks/GmRau2v0TXmDi0j_wwXSWQ/details and rerun/completed the original task.