1402964 - Twitter.com: visible loading spinner when video loops

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Mike Taylor [:miketaylr]]

STR: In Firefox, open https://twitter.com/davatron5000/status/912404469115125765

Expected: don't see a loader image for each loop
Actual... I do.

I don't know if we got faster as this recently, or something changed on Twitter's end. Not ready to mark as a regression just yet.

(note I see the loader image just once in Chrome)

Comment 1

[Mike Taylor [:miketaylr]]

OK, so there's def a regression. mozregression dies here though (around Firefox 51?)

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1a5b53a831e5a6c20de1b081c774feb3ff76756c&tochange=506facea63169a29e04eb140663da1730052db64

Anthony, there's a few media-related changesets there, can you help finding the suspicious ones?

Comment 2

[Blake Wu [:bwu][:blakewu]]

If I set loop with the src file, https://video.twimg.com/tweet_video/DKmC_cCVAAAmuRt.mp4, there is no spinner.
It seems that spinner is not from our video control. We may need to figure out which condition may show that spinner.  
Ray, 
Do you know how to check if that spinner is ours or not?

Comment 3

[Ray Lin[:ralin]]

I see the spinner loop as well on twitter. Our spinner looks like: http://searchfox.org/mozilla-central/source/toolkit/themes/shared/media/throbber.png

Also, I spot some event handlers register on video, like loadstart/ended, not sure if those are something cause the spinner showing up.

Comment 4

[Ray Lin[:ralin]]

One more clue, if no "controns" attribute present in <video>, we don't show anything over it including spinner. Hope this helps :D

Comment 5

[Ray Lin[:ralin]]

s/controns/controls/

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

JW - maybe we're firing some weird events.

Comment 7

[Mike Taylor [:miketaylr]]

[Tracking Requested - why for this release]: Dunno if we want this to track 57, it's a perceived quality/performacne issue (IMHO) on a very popular website.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This does seem like something we should try to fix, tracked for 57.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

It looks like the spinner is caused by the 'waiting' event. We should contact the site owner to fix their code because firing 'waiting' events during seeking conforms to the spec.

Comment 10

[Chris Peterson [:cpeterson]]

I will contact Twitter. This tweet is broken in Edge (but not IE11) for a different reason: only part of the animated background is animated (except when scrolling the page).

Comment 11

[Kilik Kuo [:kikuo] (inactive)]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #9)
> It looks like the spinner is caused by the 'waiting' event. We should
> contact the site owner to fix their code because firing 'waiting' events
> during seeking conforms to the spec.

For reference, the "waiting" event here causes this spinner appearing.

http://searchfox.org/mozilla-central/rev/298033405057ca7aa5099153797467eceeaa08b5/dom/html/HTMLMediaElement.cpp#5886

Comment 12

[drichards]

Twitter employee here, this is a regression on our end that we'll address. Thank you for raising this!

Comment 13

[Alastor Wu [:alwu]]

Per comment12, mark this bug as invalid.

Comment 15

[Chris Peterson [:cpeterson]]

Twitter fixed this animation bug on March 15. Animations loop smoothly in Firefox now!