Closed Bug 1402969 Opened 7 years ago Closed 7 years ago

Merge nsGlobalChromeWindow into nsGlobalWindow

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file, 1 obsolete file)

Merge nsGlobalChromeWindow into nsGlobalWindow
28.16 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
We already expose most of the nsGlobalChromeWindow methods directly on nsGlobalWindow right now for convenience, so it seems mildly silly that we still keep them separate. In addition, we never reference nsGlobalChromeWindow outside of the implementation.

Might as well merge them.
Looks like you removed a bunch of stuff in bug 1400898, so I'm going to cancel review until I rebase.
Attachment #8911971 - Flags: review?(bzbarsky)
Attachment #8911971 - Attachment is obsolete: true
Summary: Merge nsGlobalChromeWindow into nsGlobalWindo → Merge nsGlobalChromeWindow into nsGlobalWindow
Comment on attachment 8912003 [details] [diff] [review]
Merge nsGlobalChromeWindow into nsGlobalWindow

r=me
Attachment #8912003 - Flags: review?(bzbarsky) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/305344590683
Merge nsGlobalChromeWindow into nsGlobalWindow, r=bz
https://hg.mozilla.org/mozilla-central/rev/305344590683
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: