Move the TransceiverImpls out of PeerConnectionMedia, and rename PCM
Categories
(Core :: WebRTC: Signaling, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(3 files)
We're awfully close to being able to rename PeerConnectionMedia to something like PeerConnectionTransportManager, since that is mostly what it does now. But it still owns the TransceiverImpls, which is a bit at-odds with the rest of its functionality. These should probably be relocated to PeerConnectionImpl.
Updated•7 years ago
|
Assignee | ||
Comment 1•2 years ago
•
|
||
Blocks 1624989 because moving the op chain to PCImpl creates cycles in c++. Breaking these cycles will require making PCImpl cycle collected, which will in turn mean that we do not get the opportunity to manually trigger cleanup in PCImpl to break cycles ourselves, which in turn means that other cycle-collected stuff (like TransceiverImpl) will need to live someplace cycle-collected too (ie; PCImpl).
It may end up being simplest to move all of PCMedia into PCImpl, and remove any duplicate members.
Comment 2•2 years ago
|
||
I don't have any work that would conflict with this, and in general I agree with combining the two.
Assignee | ||
Comment 3•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D138543
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D138544
Assignee | ||
Comment 6•2 years ago
|
||
https://treeherder.mozilla.org/jobs?repo=try&revision=0ef15ffd318a746d49ef4642cbbf6a8be5906013
https://treeherder.mozilla.org/jobs?repo=try&revision=7e07e1d2a952ddb0483076b2703e9112398f3da1
https://treeherder.mozilla.org/jobs?repo=try&revision=5e13faa1320c09911ca54857a2453e08e8af1b12
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0671aadc65cc3178fec76e69342a986659d404e8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f406c270396a7fde0621a77ab5f86d69bae0083
Assignee | ||
Comment 7•2 years ago
|
||
Assignee | ||
Comment 8•2 years ago
•
|
||
Maybe seeing a new orange here?
Here's a baseline push on that job:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a168aa0911d67106ca59255f7a895a4c1d75c4f
Edit: Seems super rare, but might be new? Hard to say.
Assignee | ||
Comment 9•2 years ago
|
||
Ok, that failure does not seem to be happening with retriggers. I'm going to guess it is a pre-existing, extremely rare, intermittent.
Comment 10•2 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15a193032c7a Move PCMedia's functionality to PCImpl. r=mjf https://hg.mozilla.org/integration/autoland/rev/d33dccdb2864 Some simplifications. r=mjf https://hg.mozilla.org/integration/autoland/rev/8f2b89c766e4 Fix bug where PeerConnectionWrapper would crash if PeerConnectionCtx is shut down. r=mjf
Comment 11•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/15a193032c7a
https://hg.mozilla.org/mozilla-central/rev/d33dccdb2864
https://hg.mozilla.org/mozilla-central/rev/8f2b89c766e4
Description
•