Closed Bug 1402997 Opened 7 years ago Closed 2 years ago

Move the TransceiverImpls out of PeerConnectionMedia, and rename PCM

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(3 files)

We're awfully close to being able to rename PeerConnectionMedia to something like PeerConnectionTransportManager, since that is mostly what it does now. But it still owns the TransceiverImpls, which is a bit at-odds with the rest of its functionality. These should probably be relocated to PeerConnectionImpl.
Rank: 25
Priority: -- → P3

Blocks 1624989 because moving the op chain to PCImpl creates cycles in c++. Breaking these cycles will require making PCImpl cycle collected, which will in turn mean that we do not get the opportunity to manually trigger cleanup in PCImpl to break cycles ourselves, which in turn means that other cycle-collected stuff (like TransceiverImpl) will need to live someplace cycle-collected too (ie; PCImpl).

It may end up being simplest to move all of PCMedia into PCImpl, and remove any duplicate members.

Blocks: 1624989

I don't have any work that would conflict with this, and in general I agree with combining the two.

Assignee: nobody → docfaraday
Status: NEW → ASSIGNED

Depends on D138543

Blocks: 1755318
No longer blocks: 1624989

Ok, that failure does not seem to be happening with retriggers. I'm going to guess it is a pre-existing, extremely rare, intermittent.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15a193032c7a
Move PCMedia's functionality to PCImpl. r=mjf
https://hg.mozilla.org/integration/autoland/rev/d33dccdb2864
Some simplifications. r=mjf
https://hg.mozilla.org/integration/autoland/rev/8f2b89c766e4
Fix bug where PeerConnectionWrapper would crash if PeerConnectionCtx is shut down. r=mjf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: