1403012 - Running "mach test" with no args fails with TypeError: run_python_tests() got an unexpected keyword argument 'log'

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Running ./mach test on Mac, I get the error pasted below. I have tried this with a fresh checkout of m-c, and already ran mach bootstrap and an artifact build.

---

agashlin-30802:mozilla-central-second agashlin$ ./mach test
Error running mach:

    ['test']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: No module named autotry

  File "/Users/agashlin/nobackup/mozilla-central-second/testing/mach_commands.py", line 260, in test
    from autotry import AutoTry
  File "/Users/agashlin/nobackup/mozilla-central-second/build/mach_bootstrap.py", line 351, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)

Comment 1

[Andrew Halberstadt [:ahal]]

This got fixed awhile back, though there's a new error now:

TypeError: run_python_tests() got an unexpected keyword argument 'log'

  File "/home/ahal/hg/mozilla-central/testing/mach_commands.py", line 166, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach_commands.py", line 88, in python_test
    return self.run_python_tests(*args, **kwargs)

Rather than close and re-open a new bug, I'm going to hijack this one.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1403012 - Fix TypeError when running python unittests via |mach test|,

Mach test now creates a structured logger and passes it down into all
of the various test harnesses. Except |mach python-test| doesn't use
structured logging yet, so the argument is not expected.

For now, just accept **kwargs and ignore the logger. Eventually we'll
want to get python tests to use structured logging, and we can use it
at that point.

Review commit: https://reviewboard.mozilla.org/r/212516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212516/

Comment 3

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Comment on attachment 8942232 [details]
Bug 1403012 - Fix TypeError when running python unittests via |mach test|,

https://reviewboard.mozilla.org/r/212516/#review218240

That approach seems very sensible.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ce7df5790d
Fix TypeError when running python unittests via |mach test|, r=gbrown

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/83ce7df5790d