Running "mach test" with no args fails with TypeError: run_python_tests() got an unexpected keyword argument 'log'

RESOLVED FIXED in Firefox 59

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: agashlin, Assigned: ahal)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Running ./mach test on Mac, I get the error pasted below. I have tried this with a fresh checkout of m-c, and already ran mach bootstrap and an artifact build.

---

agashlin-30802:mozilla-central-second agashlin$ ./mach test
Error running mach:

    ['test']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: No module named autotry

  File "/Users/agashlin/nobackup/mozilla-central-second/testing/mach_commands.py", line 260, in test
    from autotry import AutoTry
  File "/Users/agashlin/nobackup/mozilla-central-second/build/mach_bootstrap.py", line 351, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
Component: mach → General
Product: Core → Testing
This got fixed awhile back, though there's a new error now:

TypeError: run_python_tests() got an unexpected keyword argument 'log'

  File "/home/ahal/hg/mozilla-central/testing/mach_commands.py", line 166, in test
    argv=extra_args, test_objects=tests, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "/home/ahal/hg/mozilla-central/python/mach_commands.py", line 88, in python_test
    return self.run_python_tests(*args, **kwargs)

Rather than close and re-open a new bug, I'm going to hijack this one.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Summary: Running "mach test" with no args fails with missing module autotry → Running "mach test" with no args fails with TypeError: run_python_tests() got an unexpected keyword argument 'log'
Comment on attachment 8942232 [details]
Bug 1403012 - Fix TypeError when running python unittests via |mach test|,

https://reviewboard.mozilla.org/r/212516/#review218240

That approach seems very sensible.
Attachment #8942232 - Flags: review?(gbrown) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83ce7df5790d
Fix TypeError when running python unittests via |mach test|, r=gbrown
https://hg.mozilla.org/mozilla-central/rev/83ce7df5790d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.