Assertion failure: invertible, at layout/svg/nsFilterInstance.cpp:80

RESOLVED FIXED in Firefox 58

Status

()

defect
P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: bc, Assigned: u459114)

Tracking

(Blocks 1 bug, {assertion})

57 Branch
mozilla58
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox56 wontfix, firefox57 wontfix, firefox58 fixed)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Posted file Windows Debug Log
1. https://www.dobreprogramy.pl/Paragon-Backup-Recovery%2CProgram%2CWindows%2C15537.html

2. Assertion failure: invertible, at z:/build/build/src/layout/svg/nsFilterInstance.cpp:80
#01: nsFilterInstance::PaintFilteredFrame(nsIFrame *,gfxContext *,nsSVGFilterPaintCallback *,nsRegion const *,mozilla::image::imgDrawingParams &) [layout/svg/nsFilterInstance.cpp:80]
#02: nsSVGUtils::PaintFrameWithEffects(nsIFrame *,gfxContext &,mozilla::gfx::BaseMatrix<double> const &,mozilla::image::imgDrawingParams &,mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const *) [layout/svg/nsSVGUtils.cpp:862]
#03: nsSVGMaskFrame::GetMaskForMaskedFrame(nsSVGMaskFrame::MaskParams &) [layout/svg/nsSVGMaskFrame.cpp:112]
#04: CreateAndPaintMaskSurface [layout/svg/nsSVGIntegrationUtils.cpp:544]
#05: nsSVGIntegrationUtils::PaintMaskAndClipPath(nsSVGIntegrationUtils::PaintFramesParams const &) [layout/svg/nsSVGIntegrationUtils.cpp:928]

Beta/57, Nightly/58 Windows, Linux

Assertion added in bug 1385239
Flags: needinfo?(cku)
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → cku
Flags: needinfo?(cku)
(Assignee)

Comment 1

2 years ago
in bug 1385239, I did not add this assertion, but only move this assertion from the caller to the callee. I will check it tomorrow
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8914206 - Flags: review?(mstange)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8914206 [details]
Bug 1403057 - Early return if the scale vector is zero.

https://reviewboard.mozilla.org/r/185528/#review190768
Attachment #8914206 - Flags: review?(mstange) → review+

Comment 4

2 years ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bc1f7a2c74e
Early return if the scale vector is zero. r=mstange
https://hg.mozilla.org/mozilla-central/rev/8bc1f7a2c74e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Can we land a test for this? And should we nominate this for Beta approval or can it ride the 58 train?
Flags: needinfo?(cku)
Flags: in-testsuite?
(Assignee)

Comment 7

2 years ago
I am trying to create a test case. But I don't think we need to uplift this patch since we can still render the content correctly even if hitting this assertion
(Assignee)

Updated

a year ago
Flags: needinfo?(cku)
You need to log in before you can comment on or make changes to this bug.