1403057 - Assertion failure: invertible, at layout/svg/nsFilterInstance.cpp:80

Status: RESOLVED FIXED

(Core :: SVG, defect, P2)

Description

[Bob Clary [:bc] (inactive)]

Attachment: Windows Debug Log

1. https://www.dobreprogramy.pl/Paragon-Backup-Recovery%2CProgram%2CWindows%2C15537.html

2. Assertion failure: invertible, at z:/build/build/src/layout/svg/nsFilterInstance.cpp:80
#01: nsFilterInstance::PaintFilteredFrame(nsIFrame *,gfxContext *,nsSVGFilterPaintCallback *,nsRegion const *,mozilla::image::imgDrawingParams &) [layout/svg/nsFilterInstance.cpp:80]
#02: nsSVGUtils::PaintFrameWithEffects(nsIFrame *,gfxContext &,mozilla::gfx::BaseMatrix<double> const &,mozilla::image::imgDrawingParams &,mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const *) [layout/svg/nsSVGUtils.cpp:862]
#03: nsSVGMaskFrame::GetMaskForMaskedFrame(nsSVGMaskFrame::MaskParams &) [layout/svg/nsSVGMaskFrame.cpp:112]
#04: CreateAndPaintMaskSurface [layout/svg/nsSVGIntegrationUtils.cpp:544]
#05: nsSVGIntegrationUtils::PaintMaskAndClipPath(nsSVGIntegrationUtils::PaintFramesParams const &) [layout/svg/nsSVGIntegrationUtils.cpp:928]

Beta/57, Nightly/58 Windows, Linux

Assertion added in bug 1385239

Comment 1

[u459114]

in bug 1385239, I did not add this assertion, but only move this assertion from the caller to the callee. I will check it tomorrow

Comment 2

[u459114]

Attachment: Bug 1403057 - Early return if the scale vector is zero.

Review commit: https://reviewboard.mozilla.org/r/185528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185528/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8914206 [details]
Bug 1403057 - Early return if the scale vector is zero.

https://reviewboard.mozilla.org/r/185528/#review190768

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bc1f7a2c74e
Early return if the scale vector is zero. r=mstange

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8bc1f7a2c74e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Can we land a test for this? And should we nominate this for Beta approval or can it ride the 58 train?

Comment 7

[u459114]

I am trying to create a test case. But I don't think we need to uplift this patch since we can still render the content correctly even if hitting this assertion