1403096 - The devtools permission has priority at being displayed in the pop-up over other permissions

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[CosminB]

Attachment: devtools.png

[Affected versions]:
- Firefox 58.0a1 (2017-09-25)
- Firefox 57.0b3 (20170925150345)

[Prerequisites]
- Create xpinstall.signatures.dev-root and set it to true

[Affected platforms]:
- Win 7 64-bit
- Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Click the “Add to Firefox” install button https://addons-dev.allizom.org/en-US/firefox/addon/permissions-devtools/

[Expected results]:
- As pointed in the comment (https://bugzilla.mozilla.org/show_bug.cgi?id=1339952#c1) only the hosts permission and native messaging should be at the top of the list, the rest should have no order.

[Actual results]:
- The devtools is displayed at top of the list in the permission pop-up.

Please see the attached screenshot.

Comment 1

[Andrew Swan [:aswan]]

I don't understand the issue, the only specification we have is that origin and native message permissions must come first, there is no explicit promise about the ordering of the remaining permissions (at least until we do bug 1346722).  This extension doesn't have any origin permissions nor does it have nativeMessaging so as long as all the promptable permissions are present we're handling it correctly.

Comment 2

[CosminB]

The  “devtools_page” key is the one that is displayed always at the top of the list over the remaining permissions, is this expected?
https://drive.google.com/file/d/0B3Rw2hpbuNiLeExQa3g5ZVU3eWs/view?usp=sharing 

While I investigated further more I observed that if you add “devtools” into “permissions”, it will display the permission string for devtools in the right order in the pop-up. Is this expected?
https://drive.google.com/file/d/0B3Rw2hpbuNiLeHFLZFZ4YVFlWmc/view?usp=sharing

Comment 3

[Andrew Swan [:aswan]]

Like I said, the only specification is that origin permissions and the native messaging permission must come at the top.
There is no prescribed order for other permissions.  The order we present permissions for a particular extension may change as parts of the implementation change, but as long as the requirement described above is met, that's okay.