Closed Bug 1403106 Opened 7 years ago Closed 7 years ago

Console launchpad is broken

Tracking

(firefox57 wontfix, firefox58 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 58

Tracking Flags:

Tracking

Status

firefox57

---

wontfix

firefox58

---

fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(5 files, 1 obsolete file)

Bug 1403106 - Fix console launchpad; . 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details
Bug 1403106 - Fix rewrite-lazy require for non-named modules; 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details
Bug 1403106 - Fix console launchpad layout issues; . 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details
Bug 1403106 - Use absolute path to not have issues with webpack aliasing; 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details
Bug 1403106 - Fix console launchpad for ObjectClient; 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details
Bug 1403106 - Fix mocha tests; . 7 years ago Nicolas Chevobbe [:nchevobbe] 59 bytes, text/x-review-board-request	Honza : review+	Details

Nicolas Chevobbe [:nchevobbe]

Assignee

Description

•

7 years ago

there is an error in the console : 
ERROR in ../shared/components/reps/reps.js
  Module not found: Error: Can't resolve 'devtools/client/shared/vendor/lodash'
in '/mnt/desktop/gecko/devtools/client/shared/components/reps'

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

7 years ago

Assignee: nobody → nchevobbe

Status: NEW → ASSIGNED

Priority: -- → P1

Comment hidden (mozreview-request)

Adding a new alias for lodash in webpack config.

Review commit: https://reviewboard.mozilla.org/r/183554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183554/

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 2

•

7 years ago

mozreview-review

Comment on attachment 8912169 [details]
Bug 1403106 - Fix console launchpad; .

https://reviewboard.mozilla.org/r/183554/#review188704

Thanks!

R+

Honza

Attachment #8912169 - Flags: review?(odvarko) → review+

Comment hidden (mozreview-request)

Adding proper mocks for ObjectClient so we can fetch prototype,
properties, entries and symbols in the launchpad."

Review commit: https://reviewboard.mozilla.org/r/183568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183568/

Comment hidden (mozreview-request)

Fixing layout issue both in launchpad startup (panel for selecting a debugee), and
the console launchpad (scrollbar was missing on console output).

Review commit: https://reviewboard.mozilla.org/r/183570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183570/

Julian Descottes [:jdescottes]

Updated

•

7 years ago

Updated

•

7 years ago

Depends on: 1403175

Comment hidden (mozreview-request)

Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183568/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8912194 [details]
Bug 1403106 - Fix console launchpad layout issues; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183570/diff/1-2/

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

7 years ago

Attachment #8912169 - Attachment is obsolete: true

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 7

•

7 years ago

mozreview-review

Comment on attachment 8912194 [details]
Bug 1403106 - Fix console launchpad layout issues; .

https://reviewboard.mozilla.org/r/183570/#review189188

Looks reasonable to me.

Honza

Attachment #8912194 - Flags: review?(odvarko) → review+

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 8

•

7 years ago

mozreview-review

Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

https://reviewboard.mozilla.org/r/183568/#review189190

::: devtools/client/webconsole/new-console-output/test/fixtures/ObjectClient.js:436
(Diff revision 2)
> + *        The debugger client parent.
> + * @param grip Object
> + *        A SymbolIteratorActor grip returned by the protocol via
> + *        TabActor.enumSymbols request.
> + */
> +function SymbolIteratorClient(client, grip) {

A lot of copy-pasted stuff here. Couldn't we reuse at least the SymbolIteratorClient

Could we split the shared/client/main.js module and than use SymbolIteratorClient.js as is in the tests?

Honza

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 9

•

7 years ago

you're right, it would be a lot nicer.

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

7 years ago

Depends on: 1403895

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/186354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186354/

Comment hidden (mozreview-request)

This removes the fixtures for ObjectClient since it's now in its
own file, and add one for the DebuggerClient, because it's still
using non-web dependency (e.g. `Cu`).

Review commit: https://reviewboard.mozilla.org/r/186356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186356/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/186358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186358/

Comment hidden (mozreview-request)

Comment on attachment 8912194 [details]
Bug 1403106 - Fix console launchpad layout issues; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183570/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183568/diff/2-3/

Brian Grinstead [:bgrins]

Updated

•

7 years ago

status-firefox57: --- → wontfix

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 15

•

7 years ago

mozreview-review

Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

https://reviewboard.mozilla.org/r/183568/#review191780

LGTM!
Honza

Attachment #8912193 - Flags: review?(odvarko) → review+

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 16

•

7 years ago

mozreview-review

Comment on attachment 8915094 [details]
Bug 1403106 - Fix mocha tests; .

https://reviewboard.mozilla.org/r/186358/#review191784

Attachment #8915094 - Flags: review?(odvarko) → review+

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 17

•

7 years ago

mozreview-review

Comment on attachment 8915093 [details]
Bug 1403106 - Fix console launchpad for ObjectClient;

https://reviewboard.mozilla.org/r/186356/#review191786

R+

Attachment #8915093 - Flags: review?(odvarko) → review+

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 18

•

7 years ago

mozreview-review

Comment on attachment 8915092 [details]
Bug 1403106 - Use absolute path to not have issues with webpack aliasing;

https://reviewboard.mozilla.org/r/186354/#review191788

Thanks Nicolas for fixing this!

Honza

Attachment #8915092 - Flags: review?(odvarko) → review+

Pulsebot

Comment 19

•

7 years ago

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd6062864376
Fix console launchpad layout issues; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/e7cc6e7ba559
Fix rewrite-lazy require for non-named modules; r=Honza
https://hg.mozilla.org/integration/autoland/rev/7b8c069ea7be
Use absolute path to not have issues with webpack aliasing; r=Honza
https://hg.mozilla.org/integration/autoland/rev/d7561fda2d13
Fix console launchpad for ObjectClient; r=Honza
https://hg.mozilla.org/integration/autoland/rev/7cc6c0d5edc2
Fix mocha tests; r=Honza.

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 20

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/cd6062864376
https://hg.mozilla.org/mozilla-central/rev/e7cc6e7ba559
https://hg.mozilla.org/mozilla-central/rev/7b8c069ea7be
https://hg.mozilla.org/mozilla-central/rev/d7561fda2d13
https://hg.mozilla.org/mozilla-central/rev/7cc6c0d5edc2

Status: ASSIGNED → RESOLVED

Closed: 7 years ago

status-firefox58: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 58

BMO Automation

Updated

•

6 years ago

Product: Firefox → DevTools

You need to log in before you can comment on or make changes to this bug.