Closed Bug 1403106 Opened 2 years ago Closed 2 years ago

Console launchpad is broken

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox57 wontfix, firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(5 files, 1 obsolete file)

there is an error in the console : 
ERROR in ../shared/components/reps/reps.js
  Module not found: Error: Can't resolve 'devtools/client/shared/vendor/lodash'
in '/mnt/desktop/gecko/devtools/client/shared/components/reps'
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8912169 [details]
Bug 1403106 - Fix console launchpad; .

https://reviewboard.mozilla.org/r/183554/#review188704

Thanks!

R+

Honza
Attachment #8912169 - Flags: review?(odvarko) → review+
See Also: → 1403175
Depends on: 1403175
Attachment #8912169 - Attachment is obsolete: true
Comment on attachment 8912194 [details]
Bug 1403106 - Fix console launchpad layout issues; .

https://reviewboard.mozilla.org/r/183570/#review189188

Looks reasonable to me.

Honza
Attachment #8912194 - Flags: review?(odvarko) → review+
Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

https://reviewboard.mozilla.org/r/183568/#review189190

::: devtools/client/webconsole/new-console-output/test/fixtures/ObjectClient.js:436
(Diff revision 2)
> + *        The debugger client parent.
> + * @param grip Object
> + *        A SymbolIteratorActor grip returned by the protocol via
> + *        TabActor.enumSymbols request.
> + */
> +function SymbolIteratorClient(client, grip) {

A lot of copy-pasted stuff here. Couldn't we reuse at least the SymbolIteratorClient

Could we split the shared/client/main.js module and than use SymbolIteratorClient.js as is in the tests?

Honza
you're right, it would be a lot nicer.
Depends on: 1403895
Comment on attachment 8912193 [details]
Bug 1403106 - Fix rewrite-lazy require for non-named modules;

https://reviewboard.mozilla.org/r/183568/#review191780

LGTM!
Honza
Attachment #8912193 - Flags: review?(odvarko) → review+
Comment on attachment 8915093 [details]
Bug 1403106 - Fix console launchpad for ObjectClient;

https://reviewboard.mozilla.org/r/186356/#review191786

R+
Attachment #8915093 - Flags: review?(odvarko) → review+
Comment on attachment 8915092 [details]
Bug 1403106 - Use absolute path to not have issues with webpack aliasing;

https://reviewboard.mozilla.org/r/186354/#review191788

Thanks Nicolas for fixing this!

Honza
Attachment #8915092 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd6062864376
Fix console launchpad layout issues; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/e7cc6e7ba559
Fix rewrite-lazy require for non-named modules; r=Honza
https://hg.mozilla.org/integration/autoland/rev/7b8c069ea7be
Use absolute path to not have issues with webpack aliasing; r=Honza
https://hg.mozilla.org/integration/autoland/rev/d7561fda2d13
Fix console launchpad for ObjectClient; r=Honza
https://hg.mozilla.org/integration/autoland/rev/7cc6c0d5edc2
Fix mocha tests; r=Honza.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.