1403108 - [cs] Remove Twitter search module from mobile

Status: RESOLVED FIXED

(Mozilla Localizations :: cs / Czech, enhancement)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Twitter search is the only search engine special for Fennec. All other engines are unified between all products.

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

How important is the Twitter search engine? Are we obligated or recommended to keep it?

Comment 2

[Francesco Lodolo [:flod]]

Delphine is the PM in charge of mobile products, redirecting NI.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Hey Michal. No, Twitter isn't an obligation. I can remove it when I get back next week. I'll leave the ni on me to take care of this.

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I probably know, where to remove it from Fennec, but we should probably remove it from everywhere (all Firefoxes for Android, iOS and Focuses).

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

l10n "controls" the search engines only on Firefox for Android. If you want to take a shot, go for it :) Documentation is here: https://github.com/mozilla-l10n/documentation/blob/master/products/searchplugins/setup_searchplugins.md

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Michal: you wanted to work on the patch from what I understand in comment 4. Let me know if I misunderstood or if that's the case (no rush, just want to make sure I got it). Thanks

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Sorry for my inactivity, I have lost track of this ticket. Assigning myself to create a patch before the weekend.

Comment 8

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403108 - [cs] Unify mobile search engines list with browser,

Review commit: https://reviewboard.mozilla.org/r/189048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189048/

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8918179 [details]
Bug 1403108 - [cs] Unify mobile search engines list with browser,

https://reviewboard.mozilla.org/r/189048/#review194610

Thanks Michal! There are a few things to go over I think. First of all I didn't realize that you didn't have Yahoo and Bing listed in your list.json, and we are now required to have them. They should appear first as "google", "yahoo", "bing" and the rest of the searchplugins should rather be in alphabetical order. It seems like the wikipedia.xml is a bit outdated too and could use a refresh (not sure how important it is to update it, but probably it's best). Since you're going to add Yahoo and Bing, you're also going to have to edit the mobile_region.properties file as well. All the details can be found here: https://github.com/mozilla-l10n/documentation/blob/master/products/searchplugins/setup_searchplugins.md  Thank you!

Comment 10

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi :delphine.

Is it really necessary to add those two? I remember we have removed them on purpose in the past, because they did not work well for Czech queries. I see it got better, but Yahoo still yields results mostly in English, and the interface is in English too.

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

On extra note: adding Yahoo and Bing we will end up having 4 generic search engines - Google, Yahoo, Bing and Seznam...

Comment 12

[Delphine Lebédel [:delphine - Use needinfo]]

Hey Michal - thanks for raising those valid points, I wasn't aware of that. I'll check in and see if this is still a hard requirement or not!

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

Hi Mike: when I started working on l10n mobile, I was told the requirements for Firefox Android searchengines were "google, yahoo, bing". 
It's been a while now, and I'm wondering if these "hard requirements" had shifted at all since then. Especially when I read comment 10, it doesn't seem to make much sense to add them there. I believe there were other cases in the recent past when this seemed to not make much sense anymore too. Let me know, thanks!

Comment 14

[Mike Kaply [:mkaply]]

Moving needinfo over to Mike Connor who will know more about our actual requirements of engines in particular countries.

Comment 15

[Delphine Lebédel [:delphine - Use needinfo]]

Hey Michal - so flod and I met with Joanne yesterday (from Business Development, I've CCed her here in case you had any questions) and it seems like there are global deals Mozilla has and that we can not break in this case. Joanne advised that we should be adding Bing to the existing list here, at the very least (it's OK to drop Yahoo).

This should also be reflected on desktop as a matter of fact. Please let Joanne and/or I know here if you have any questions about this, and we can try to help clarify. 

Otherwise, jumping back on my review comments from comment 9: wikipedia.xml is fine, no need to update it ;) Please ignore that part.

thanks Michal!

Comment 16

[Joanne Nagel]

I want to be super explicit here - we are only removing Yahoo for this particular locale because the results are in English and not localized.  We'll be reviewing any changes in the future on a case by case basis.  thanks everyone!

Comment 17

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Comment on attachment 8918179 [details]
Bug 1403108 - [cs] Unify mobile search engines list with browser,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189048/diff/1-2/

Comment 18

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403108 - Add Bing search engine for mobile

Update for region.properties.

Comment 19

[Francesco Lodolo [:flod]]

Comment on attachment 8923172 [details] [diff] [review]
Bug 1403108 - Add Bing search engine for mobile

Review of attachment 8923172 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/chrome/region.properties
@@ +13,5 @@
>  # cause Firefox to re-read these prefs and inject any new handlers into the
>  # profile database.  Note that "new" is defined as "has a different URL"; this
>  # means that it's not possible to update the name of existing handler, so
>  # don't make any spelling errors here.
> +gecko.handlerService.defaultHandlersVersion=4

No need to update the handler version if you only change search.

Comment 20

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403108 - Add Bing search engine for mobile

Sorry. The lost bullet in https://github.com/mozilla-l10n/documentation/blob/master/products/searchplugins/setup_searchplugins.md#setting-up-files-for-locales-repository confused me.

Comment 21

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8918179 [details]
Bug 1403108 - [cs] Unify mobile search engines list with browser,

https://reviewboard.mozilla.org/r/189048/#review200218

lgtm!

Comment 22

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you Delphine. One extra question, in which order should be these patches landed? Does it matter we have x-channel now and the l10n-central change would go straight to beta two weeks before the merge day?

Comment 23

[Francesco Lodolo [:flod]]

This is an interesting case for cross-channel. Luckily, it's not a sensitive change.

l10n-central will have Bing set as 2nd searchplugin, no problems there.
If we ship this change in Beta, it will try to set Bing as 2nd searchplugin, but the file won't be enabled for cs.

I'd suggest to land the one in l10n-central/cs starting from tomorrow, so it doesn't affect 57. We can land the mozilla-central anytime (I'll trigger the landing).

Comment 24

[Francesco Lodolo [:flod]]

Comment on attachment 8918179 [details]
Bug 1403108 - [cs] Unify mobile search engines list with browser,

https://reviewboard.mozilla.org/r/189048/#review200356

(need a l3 review to land)

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45ce5a8174d0
[cs] Unify mobile search engines list with browser, r=delphine,flod

Comment 26

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

NI myself to not forgot and push it to l10n-central/cs later tomorrow.

Thank you for pushing the other patch to autoland.

Comment 27

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/45ce5a8174d0

Comment 28

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

https://hg.mozilla.org/l10n-central/cs/rev/b75bcf5ed14e