1403111 - [cs] Different search engines icons for mail and suite

Status: RESOLVED FIXED

(Mozilla Localizations :: cs / Czech, enhancement)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

For mail (https://transvision.mozfr.org/productization/?locale=cs&product=mail) and suite (https://transvision.mozfr.org/productization/?locale=cs&product=suite) I see a different set of engines compared to browser (https://transvision.mozfr.org/productization/?locale=cs&product=browser). Namely:
- duckduckgo-cz.xml (with broken icon in the Transvision view) is used instead of ddg.xml
- google.xml for mail has some old icon
- wikipedia-cz.xml icon for suite is smaller than the icons for browser and mail

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

For point 1 and 2, I can update the icons. but for the last one, what is the expected icon size for the search icons? Shouldn't we actually update the smaller icons to some bigger resolution?

Comment 2

[Francesco Lodolo [:flod]]

Icon for Firefox desktop are .ico, embedding both 16px and 32px (Transvision only shows the smaller size). I don't have an answer for suite or mail though.

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403111 - [cs] Unify mail searchplugins with browser

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403111 - [cs] Unify suite searchplugins with browser

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8931266 [details] [diff] [review]
Bug 1403111 - [cs] Unify mail searchplugins with browser

Review of attachment 8931266 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, r+ with the following comment:

::: mail/searchplugins/heureka-cz.xml
@@ +14,2 @@
>  	<Param name="h[fraze]" value="{searchTerms}"/>
> +	<Param name="utm_source" value="firefox-search"/>

Not sure about the source parameters, I believe we need to have our own for Thunderbird, or none at all. I'll ask for f? from flod to be sure.

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8931266 [details] [diff] [review]
Bug 1403111 - [cs] Unify mail searchplugins with browser

Review of attachment 8931266 [details] [diff] [review]:
-----------------------------------------------------------------

That's mostly on the search provider, i.e. if they want to differentiate Thunderbird users from Firefox in their analytics.

For now, it's probably safer to remove the parameter, and ask the provider if they even want one for this use case.

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403111 - [cs] Unify mail searchplugins with browser, v2

Version 2 of the patch for Thunderbird, without firefox source parameters.

Comment 8

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1403111 - [cs] Unify suite searchplugins with browser, v2

Version 2 of the patch for SeaMonkey, fixing source parameters.

Comment 9

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

mail: https://hg.mozilla.org/l10n-central/cs/rev/93b3b1e0b611f82c767d2637c9c9425a8c0737ae

Comment 10

[Ian Neal]

Comment on attachment 8931373 [details] [diff] [review]
Bug 1403111 - [cs] Unify suite searchplugins with browser, v2

>+++ b/suite/searchplugins/duckduckgo-cz.xml

> <SearchForm>https://duckduckgo.com/</SearchForm>
<SearchForm> isn't needed for duckduckgo now (see /browser/locales/searchplugins/ddg.xml)

r=me with that addressed.

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you Ian. I have pushed the updated patch.

suite: https://hg.mozilla.org/l10n-central/cs/rev/1478ab2b025e9d6f9dea839c2b11f5fbc16fb56f