Closed Bug 1403136 Opened 2 years ago Closed 2 years ago

Clean up JSSetterOp code

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Bug 1153592 got rid of slotful getters/setters and there's more to clean up here:

* We can get rid of the "update the slot with the value returned by the setter" code in NativeSetExistingDataProperty.

* After that, JSSetterOp no longer needs a MutableHandleValue and can just take a HandleValue.

* cx->propertyRemovals can be removed.
Attachment #8912186 - Flags: review?(evilpies)
Comment on attachment 8912186 [details] [diff] [review]
Patch

Review of attachment 8912186 [details] [diff] [review]:
-----------------------------------------------------------------

So nice!
Attachment #8912186 - Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0da5d64aded
Clean up JSSetterOp code now that slotful setters are gone. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/f0da5d64aded
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.