1403175 - Cleanup devtools webpack shims

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

The goal of this bug is to gather all the shims currently used by launchpad consumers in mozilla-central (console, netmonitor & inspector).

The shims should all be in the same location in m-c to avoid duplication & confusion. 

We can also discuss whether some shims should be move to launchpad or not.

Comment 1

[Julian Descottes [:jdescottes]]

Here is the list of shims we use from m-c:
- "devtools/client/webconsole/jsterm": devtools/client/local-dev/jsterm-stub.js
- "devtools/client/webconsole/utils": devtools/client/new-console-output/test/fixtures/WebConsoleUtils.js
- "devtools/client/framework/devtools": devtools/client/shims/devtools.js
- "devtools/shared/system": devtools/client/local-dev/system-stub.js
- "devtools/shared/fronts/timeline": devtools/shared/shims/fronts/timeline.js
- "devtools/shared/platform/clipboard": devtools/shared/platform/content/clipboard.js
- "devtools/shared/platform/stack": devtools/shared/platform/content/stack.js

Which means our shims are found in 5 folders:
- devtools/client/local-dev/
- devtools/client/new-console-output/test/fixtures/
- devtools/client/shims/
- devtools/shared/shims/
- devtools/shared/platform/content/

I think we should move them all to devtools/shared/webpack/shims. I will leave out devtools/shared/platform/content/ for which the situation is a bit more a complex. I logged Bug 1403489 to address this.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1403175 - webpack: simplify netmonitor & console aliases;

Review commit: https://reviewboard.mozilla.org/r/183952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183952/

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1403175 - move webpack shims to dedicated folder;

Review commit: https://reviewboard.mozilla.org/r/183954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183954/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8912628 [details]
Bug 1403175 - webpack: simplify netmonitor & console aliases;

https://reviewboard.mozilla.org/r/183952/#review189120

just tested the console and it works well.
Thanks Julian

::: devtools/client/netmonitor/webpack.config.js:100
(Diff revision 1)
>        "devtools/shim/locales": path.join(__dirname, "../../shared/locales/en-US"),
>        "toolkit/locales": path.join(__dirname, "../../../toolkit/locales/en-US"),
> +
> +      // Unless a path explicitly needs to be rewritten or shimmed, all devtools paths can
> +      // be mapped to ../../
> +      "devtools": path.join(__dirname, "../../"),

great !

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the review Nicolas! 

Note that this patch makes the first patch attached to Bug 1403106 redundant, so feel free to block your bug on mine to avoid conflicts :)

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8912628 [details]
Bug 1403175 - webpack: simplify netmonitor & console aliases;

https://reviewboard.mozilla.org/r/183952/#review189174

Excellent, thanks!

Net monitor tested with the Launchpad and works as expected.

R+

Honza

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8912629 [details]
Bug 1403175 - move webpack shims to dedicated folder;

https://reviewboard.mozilla.org/r/183954/#review189176

LGTM!

Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4362432d8d32
webpack: simplify netmonitor & console aliases;r=Honza,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/925bee759927
move webpack shims to dedicated folder;r=Honza

Comment 9

[Julian Descottes [:jdescottes]]

Thanks for the reviews! Landing

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4362432d8d32
https://hg.mozilla.org/mozilla-central/rev/925bee759927