1403188 - Migrate browser_console_private_browsing.js to the new console

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1403188 - Enable browser_console_webconsole_private_browsing.js in new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/228418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228418/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Sorry this is not the most readable review :/
Hope it's clear enough though

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8959604 [details]
Bug 1403188 - Enable browser_console_webconsole_private_browsing.js in new console frontend; .

https://reviewboard.mozilla.org/r/228418/#review234344

Looks good! Thanks a lot for migrating this complex test.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_webconsole_private_browsing.js:35
(Diff revision 1)
> -      BrowserTestUtils.addTab(gBrowser, "data:text/html;charset=utf8," +
> -                                        "<p>hello world! I am not private!");
> -    gBrowser.selectedBrowser.addEventListener("load", onLoadTab, true);
> -  }
> -
> -  function onLoadTab() {
> +add_task(async function() {
> +  await addTab(NON_PRIVATE_TEST_URI);
> +
> +  // On e10s, the exception is triggered in child process and is ignored by test harness.
> +  if (!Services.appinfo.browserTabsRemoteAutostart) {
> +    expectUncaughtException();

Test fails with --disable-e10s for me. Since we wrap the exception, I don't think we should expect uncaught exception here?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8959604 [details]
Bug 1403188 - Enable browser_console_webconsole_private_browsing.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228418/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b801fbf9bc4
Enable browser_console_webconsole_private_browsing.js in new console frontend; r=jdescottes.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7b801fbf9bc4