Closed Bug 1403195 Opened 7 years ago Closed 7 years ago

userguide.html contains invalid markup

Categories

(Tree Management :: Treeherder, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Seen whilst working on bug 1364894.

https://validator.nu/?doc=https%3A%2F%2Fraw.githubusercontent.com%2Fmozilla%2Ftreeherder%2Fa8acc7461ef5edd67f0440205f903676e4d6ea7b%2Fui%2Fuserguide.html&parser=html5&laxtype=yes&showsource=yes

eg:

Error: End tag td seen, but there were open elements.
From line 143, column 76; to line 143, column 80
ss="kbd">c</td>↩     

Error: Unclosed element span.
From line 143, column 57; to line 143, column 74
md</span>+<span class="kbd">c</td>

Error: Stray end tag span.
From line 146, column 21; to line 146, column 27
          </span> logvi

Error: End tag td seen, but there were open elements.
From line 149, column 76; to line 149, column 80
ss="kbd">c</td>↩     

Error: Unclosed element span.
From line 149, column 57; to line 149, column 74
md</span>+<span class="kbd">c</td>

Error: End tag td seen, but there were open elements.
From line 155, column 76; to line 155, column 80
ss="kbd">c</td>↩     

Error: Unclosed element span.
From line 155, column 57; to line 155, column 74
md</span>+<span class="kbd">c</td>

--

In addition, looking at production the styling is broken in a few places too.
Blocks: 1339508, 1139421
Attachment #8912267 - Flags: review?(cdawson)
Attachment #8912267 - Flags: review?(cdawson) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d26651edb445c5d1532bce99ebba3f85deefdfca
Bug 1403195 - Fix styling and mismatched tags in userguide.html (#2790)

The `class='kbd'` usages were missed from the changes in bug 1339508.
The mismatched tags have been present since the original landing in
bug 1139421.

Also removes a stray whitespace character from index.html.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: