Closed Bug 1403204 Opened 5 years ago Closed 5 years ago

Code that configures telephone-event assumes that it is always last in the codec array

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bwc, Assigned: dminor)

Details

Attachments

(1 file)

Spotted by drno.

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/MediaPipelineFactory.cpp#736

This might not be the case if RED is also present. We should probably actually search the array.
Assignee: nobody → dminor
Rank: 25
Priority: -- → P3
Comment on attachment 8912387 [details]
Bug 1403204 - Code that configures telephone-event should not assume that it is always last in the codec array;

https://reviewboard.mozilla.org/r/183708/#review188920
Attachment #8912387 - Flags: review?(docfaraday) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f05e4bf0fac
Code that configures telephone-event should not assume that it is always last in the codec array; r=bwc
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3f05e4bf0fac
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.