1403204 - Code that configures telephone-event assumes that it is always last in the codec array

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Byron Campen [:bwc]]

Spotted by drno.

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/MediaPipelineFactory.cpp#736

This might not be the case if RED is also present. We should probably actually search the array.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1403204 - Code that configures telephone-event should not assume that it is always last in the codec array;

Instead, iterate over the values.

Review commit: https://reviewboard.mozilla.org/r/183708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183708/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8912387 [details]
Bug 1403204 - Code that configures telephone-event should not assume that it is always last in the codec array;

https://reviewboard.mozilla.org/r/183708/#review188920

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f05e4bf0fac
Code that configures telephone-event should not assume that it is always last in the codec array; r=bwc

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3f05e4bf0fac