1403232 - vtt.jsm is buggy is the buffer to parse is uncompleted

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Andrea Marchesini [:baku]]

in vtt.jsm there is this pattern:

while (self.buffer) {
  ...
  // If there is no cue identifier, keep the line and reuse this line
  // in next iteration.
  if (!parseCueIdentifier(line)) {
    continue;
  }

but if the line was the end of the buffer, self.buffer will be empty and the loop will not continue as the comment says.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: vtt.patch

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8912295 [details] [diff] [review]
vtt.patch

Review of attachment 8912295 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the finding.
Please remember to run the web-platform-tests and mochitest-dom-media on try.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4eb4cec5bc8a
Fixing the WebVTT parser when the buffer uncompleted, r=bechen

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4eb4cec5bc8a