Typo in webextension containers exceptions

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jkt, Assigned: jkt)

Tracking

(Blocks 1 bug)

57 Branch
Firefox 58
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

Attachments

(1 attachment)

Throwing errors with "identitiy".
Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

https://reviewboard.mozilla.org/r/183646/#review188850

I donno... I thought it added a bit of color :)
Attachment #8912313 - Flags: review?(kmaglione+bmo) → review+
Hahah, sorry I missed it. The same typo is elsewhere too though in some Java code. Will file follow up.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6408f36a3bdc
Fix typo in identity exceptions. r=kmag
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6408f36a3bdc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1395659
[User impact if declined]: Extensions might string check for exceptions and cause issues.
[Is this code covered by automated tests?]: Yes, but also changed to the correct spelling.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a text change which has tests (granted they had to be changed to)
[String changes made/needed]: N/A
Attachment #8912313 - Flags: approval-mozilla-beta?
Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

Fix a typo, taking it in 57b4
Attachment #8912313 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Jonathan Kingston [:jkt] from comment #6)
> [Is this code covered by automated tests?]: Yes, but also changed to the
> correct spelling.
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: N/A

Setting qe-verify- based on Jonathan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.