1403243 - Typo in webextension containers exceptions

Status: RESOLVED FIXED

(Firefox :: Security, defect)

Description

[Jonathan Kingston [:jkt] he/him]

Throwing errors with "identitiy".

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1403243 - Fix typo in identity exceptions.

Review commit: https://reviewboard.mozilla.org/r/183646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183646/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

https://reviewboard.mozilla.org/r/183646/#review188850

I donno... I thought it added a bit of color :)

Comment 3

[Jonathan Kingston [:jkt] he/him]

Hahah, sorry I missed it. The same typo is elsewhere too though in some Java code. Will file follow up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6408f36a3bdc
Fix typo in identity exceptions. r=kmag

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6408f36a3bdc

Comment 6

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1395659
[User impact if declined]: Extensions might string check for exceptions and cause issues.
[Is this code covered by automated tests?]: Yes, but also changed to the correct spelling.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a text change which has tests (granted they had to be changed to)
[String changes made/needed]: N/A

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8912313 [details]
Bug 1403243 - Fix typo in identity exceptions.

Fix a typo, taking it in 57b4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a4ba664d41ec

Comment 9

[Andrei Vaida [:avaida]]

(In reply to Jonathan Kingston [:jkt] from comment #6)
> [Is this code covered by automated tests?]: Yes, but also changed to the
> correct spelling.
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: N/A

Setting qe-verify- based on Jonathan's assessment on manual testing needs and the fact that this fix has automated coverage.