Closed Bug 1403244 Opened 3 years ago Closed 3 years ago

Repeat bubble grows with the body of the message

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: nchevobbe, Assigned: bgrins)

References

()

Details

(Whiteboard: [reserve-console-html])

Attachments

(3 files)

Steps to reproduce:
1. Open `data:text/html,<script>function baz(){console.error("oops\n".repeat(10))}baz();baz();</script>`
2. Open the console

Expected results:
The repeat bubble looks like a bubble

Actual results:
The bubble takes the whole height of the message (see attachment)
Priority: -- → P3
Whiteboard: [console-html][triage]
Flags: qe-verify+
QA Contact: iulia.cristescu
Whiteboard: [console-html][triage] → [reserve-console-html]
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8914371 [details]
Bug 1403244 - Do not grow height of the message repeat bubble;

https://reviewboard.mozilla.org/r/185624/#review190938
Attachment #8914371 - Flags: review?(nchevobbe) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95618d452cc6
Do not grow height of the message repeat bubble;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/95618d452cc6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Attached image repeat bubble
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171005100211

This issue has been verified on latest Firefox Nightly Build ID: 20171005100211 on Windows 8.1 x64, Mac OS 10.11 and Ubuntu 14.04. On Mac and Ubuntu the bubble with the number inside looks ok.
 
On Windows the number from the bubble is not centered and it is displayed in the lower part of the bubble. On Mac and Ubuntu the number inside the bubble is displayed in the middle.

Is this expected on Windows?
Flags: needinfo?(nchevobbe)
It is not. I filed Bug 1406321 to fix this.
Thanks !
Flags: needinfo?(nchevobbe)
Considering that issue on Windows will be tracked in bug 1406321, mark this verified.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.