Closed
Bug 1403308
Opened 7 years ago
Closed 7 years ago
Attachment splitter is shown on messages without attachment.
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(thunderbird_esr5257+ fixed, thunderbird57 fixed, thunderbird58 fixed)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
(Whiteboard: TB 57 beta 1 => TB 52.5 ESR)
Attachments
(1 file)
|
1.18 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
The attachment splitter is shown also when the message has no attachment. On Linux and Windows it's not so obvious because the splitters are invisible when collapsed. But hovering them shows the up/down arrow. On Mac the splitter is always visible and disturbs the view. STR: enable on a message with attachment through right clicking on the attachment bar the 'Initially Show Attachment Pane', then go to a message without attachment and hover on the area where the attachment list should be above the status bar. With 'Initially Show Attachment Pane' unticked there is no problem.
|
Assignee | |
Comment 1•7 years ago
|
||
This fixes the issue for me.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8912383 -
Flags: review?(acelists)
Comment on attachment 8912383 [details] [diff] [review] attachmentSplitter.patch Review of attachment 8912383 [details] [diff] [review]: ----------------------------------------------------------------- Nice
Attachment #8912383 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/e9367f02e475 Don't show attachment-splitter on messages without attachment when 'Initially Show Attachment Pane' is ticked. r=aceman
|
||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 58.0
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8912383 [details] [diff] [review] attachmentSplitter.patch [Approval Request Comment] User impact if declined: visible, not working splitter. Especially good visible on Mac. Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #8912383 -
Flags: approval-comm-esr52?
Attachment #8912383 -
Flags: approval-comm-beta?
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8912383 [details] [diff] [review] attachmentSplitter.patch I've just done beta uplifts :-(
Attachment #8912383 -
Flags: approval-comm-beta? → approval-comm-beta+
|
|
||
Updated•7 years ago
|
Whiteboard: TB 57 beta 1 => TB 52.5 ESR
|
|
||
Comment 7•7 years ago
|
||
Beta (TB 57): https://hg.mozilla.org/releases/comm-beta/rev/c8f013c1114ffc87935af1d3f1bdc8343b7fc4b2
status-thunderbird57:
--- → fixed
status-thunderbird58:
--- → fixed
status-thunderbird_esr52:
--- → affected
|
|
||
Updated•7 years ago
|
Attachment #8912383 -
Flags: approval-comm-esr52? → approval-comm-esr52+
|
|
||
Comment 8•7 years ago
|
||
TB 52.5 ESR (should be tracking 57+): https://hg.mozilla.org/releases/comm-esr52/rev/1dd56ceed9f0
|
|
||
Updated•7 years ago
|
tracking-thunderbird_esr52:
--- → 57+
You need to log in
before you can comment on or make changes to this bug.
Description
•