Closed Bug 1403327 Opened 8 years ago Closed 8 years ago

build-cloud-tools: security group incoming requires a list

Categories

(Infrastructure & Operations :: RelOps: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dhouse, Assigned: dhouse)

References

Details

In build-cloud-tools, if the incoming entry in securitygroups.yml has only one include, then the yaml parsing of the include results in that object instead of a list of objects. The aws_manage_securitygroups.py code requires a list to iterate over, and stops processing with a type exception if it instead is iterating over the properties of a single object.
This was caused by a mistake on my part and not a bug in cloudtools: https://github.com/mozilla-releng/build-cloud-tools/pull/317/commits/b9fddc8d279d2c9fc7f607fd20170e55b1c8a9c9#r141180548 I found that I had missed the leading '-' before the single include and so that caused it to be included directly instead of being a single element in a list.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.