1403334 - Make sure the property value overflow is indented

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Comment 1

[Liam Hodgins]

Attachment: Bug 1403334 - Make sure the property value overflow is indented

Review commit: https://reviewboard.mozilla.org/r/183720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183720/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8912404 [details]
Bug 1403334 - Make sure the property value overflow is indented

https://reviewboard.mozilla.org/r/183720/#review189568

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fb635e2d2f
Make sure the property value overflow is indented r=gl

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing devtools' devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d355c3627e1cce42fd5b43a2877f0d48aa9a1b55

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a9fb635e2d2f81cdbde625a452fe5fed46158e6a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Push which ran failing test on more platforms: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e7be7222410583294475ff4c8bf649b9373d1760&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133739101&repo=mozilla-inbound

05:27:37     INFO -  551 INFO Toolbox opened and focused
05:27:37     INFO -  552 INFO Waiting for actor features to be detected
05:27:37     INFO -  553 INFO Selecting the ruleview sidebar
05:27:37     INFO -  554 INFO Selecting the node for '#topleft'
05:27:37     INFO -  Buffered messages logged at 05:27:37
05:27:37     INFO -  555 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of non pseudo element rules -
05:27:37     INFO -  556 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of :first-line rules -
05:27:37     INFO -  557 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of :first-letter rules -
05:27:37     INFO -  558 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of :selection rules -
05:27:37     INFO -  559 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of :before rules -
05:27:37     INFO -  560 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | #topleft has the correct number of :after rules -
05:27:37     INFO -  561 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | There are 3 gutter headings -
05:27:37     INFO -  562 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | Gutter heading is correct -
05:27:37     INFO -  563 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | Gutter heading is correct -
05:27:37     INFO -  564 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | Gutter heading is correct -
05:27:37     INFO -  565 INFO Make sure that clicking on the twisty hides pseudo elements
05:27:37     INFO -  566 INFO TEST-PASS | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | Pseudo Elements are expanded -
05:27:37     INFO -  Buffered messages finished
05:27:37    ERROR -  567 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js:45 - TypeError: expander is null
05:27:37     INFO -  Stack trace:
05:27:37     INFO -      testTopLeft@chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_pseudo-element_01.js:45:3
05:27:37     INFO -      process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:922:23
05:27:37     INFO -      walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:806:7
05:27:37     INFO -      Promise*scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:739:11
05:27:37     INFO -      schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:770:7
05:27:37     INFO -      completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:707:7
05:27:37     INFO -      onResponse@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:513:7
05:27:37     INFO -      onStopRequest@resource://gre/modules/NetUtil.jsm:131:17
05:27:37     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:798:9
05:27:37     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
05:27:37     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
05:27:37     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:798:9
05:27:37     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
05:27:37     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
05:27:37     INFO -  568 INFO Leaving test bound

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa608874b0f3
Make sure the property value overflow is indented r=gl

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa608874b0f3

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Had to back this out because of Bug 1404904
https://hg.mozilla.org/integration/mozilla-inbound/rev/508556cd3d2aa3bab0796e5da4fc0656b1342621

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout https://hg.mozilla.org/mozilla-central/rev/508556cd3d2a

Comment 11

[Liam Hodgins]

Comment on attachment 8912404 [details]
Bug 1403334 - Make sure the property value overflow is indented

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183720/diff/1-2/

Comment 12

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8912404 [details]
Bug 1403334 - Make sure the property value overflow is indented

https://reviewboard.mozilla.org/r/183720/#review222906

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1afdba933156
Make sure the property value overflow is indented. r=gl

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1afdba933156

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fde9552e7db
followup: remove leftover comment from 1afdba933156;r=me

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2fde9552e7db