Open Bug 1403354 Opened 2 years ago Updated Last year

Top sites without local visits have a no-op "Remove" context menu item (non no-op for suggested sites)


(Firefox for Android :: Activity Stream, defect, P5)

Firefox 57



Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- fix-optional
firefox62 --- fix-optional
firefox63 --- wontfix
firefox64 --- fix-optional


(Reporter: mcomella, Unassigned)



(Keywords: regression)

1) Visit a site that is not one of the default sites
2) Return to top sites, pin this site to top sites
3) Clear history in settings
4) Long-press click the top site to open the context menu

Expected: Menu does not have "Remove" item
Actual: Menu has "Remove" which does nothing

"Remove" is only expected for suggested sites and thus does not work if it's not a suggested site. Thus, we shouldn't show Remove for non-suggested sites until bug 1320806.

This is a regression from adding the ability to remove suggested sites, bug 1400825.
This bug does call into our assumption that a top site without history is a suggested site.
Priority: -- → P2
Changing this bug to be more general because bug 1404292 has the same root cause:

(In reply to Sorina Florean [:sorina] from bug 1404292 comment #0)
> Environment: 
> Device: Samsung Galaxy Note 4 (Android 5.0.1);
> Build: Beta 57.0b4;
> Steps to reproduce:
> 1. Perform a sync and open some old bookmarks;
> 2. Go to Top Sites Panel and verify that pages from step 1 are displayed; if
> not open again;
> 3. Long tap on each of them and choose "Remove".
> Expected result:
> Nothing happens.
> Actual result:
> The page is removed.
> Notes:
> I am not able to reproduce all the time so I'm not sure that with the steps
> provided the issue is visible.
> Check the video:
Summary: Visiting a site, pinning a top site, and clearing history will add no-op "Remove" button to top site context menu → Top sites without local visits have a no-op "Remove" context menu item (non no-op for suggested sites)
Duplicate of this bug: 1404292
Priority: P2 → P3
Re-triaging per

Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Too late to fix in 63. We could still take a patch for 65 and potentially for 64.
You need to log in before you can comment on or make changes to this bug.