1403389 - Some devtools splitters use cursors with a single arrow instead of a double arrow

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P5)

Description

[Julian Descottes [:jdescottes]]

STRs
- open devtools
- show split console (press escape or click on split console button)
- move mouse over splitter line between split console and the tool above

Expected result: cursor should have a double arrow going up & down
Actual result: cursor has a simple arrow.

Most horizontal splitters in devtools are using cursor: ns-resize. It should also be used for ".devtools-horizontal-splitter". Same for .devtools-side-splitter which uses "e-resize")

http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/devtools/client/themes/splitters.css#60

Should be good first bug, CSS only, for someone who wants to get started with DevTools contributions :)

Comment 1

[Abhinav Koppula]

Hi Julian,
Can I take this one?

Comment 2

[Julian Descottes [:jdescottes]]

Sure Abhinav, thank you!

Comment 3

[Abhinav Koppula]

Attachment: Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

Review commit: https://reviewboard.mozilla.org/r/184538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184538/

Comment 4

[Abhinav Koppula]

Hi Julian,
I have created a mozreview-request for this issue.
After my changes, I could see the double arrow splitter near the split-console panel in netmonitor tab and I could also see the double arrow splitter in the storage panel headers.

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8913118 [details]
Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

https://reviewboard.mozilla.org/r/184538/#review189674

Great thanks! We also need to update the following lines:
http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/devtools/client/themes/widgets.css#97-98

It's still used in a few tools such as the storage inspector (open storage inspector, resize window to switch to vertical layout -> cursor will only be n-resize)

Comment 6

[Abhinav Koppula]

Comment on attachment 8913118 [details]
Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184538/diff/1-2/

Comment 7

[Abhinav Koppula]

Comment on attachment 8913118 [details]
Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

https://reviewboard.mozilla.org/r/184538/#review189674

Have updated the review-request.

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8913118 [details]
Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

https://reviewboard.mozilla.org/r/184538/#review189792

Thank you for the quick update!

Comment 9

[Julian Descottes [:jdescottes]]

Thank you Abhinav! Let's land this.

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ceb5948ca96f -d e7da45f5f6a4: rebasing 423137:ceb5948ca96f "Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels. r=jdescottes" (tip)
merging devtools/client/themes/breadcrumbs.css and devtools/client/themes/widgets.css to devtools/client/themes/breadcrumbs.css
merging devtools/client/themes/widgets.css
warning: conflicts while merging devtools/client/themes/breadcrumbs.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Abhinav Koppula]

Comment on attachment 8913118 [details]
Bug 1403389 - Using double arrow splitter instead of single arrow splitter in dev-tools panels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184538/diff/2-3/

Comment 12

[Abhinav Koppula]

Hi Julian,
I have rebased against the latest code and have created a moz-review request since this got rejected last time.
Can you push it to TRY once?

Thanks
Abhinav

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41dcdc81b51c
Using double arrow splitter instead of single arrow splitter in dev-tools panels. r=jdescottes

Comment 14

[Julian Descottes [:jdescottes]]

Thanks for rebasing Abhinav, this time it managed to reach autoland successfully!

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41dcdc81b51c