Closed Bug 1403407 Opened 2 years ago Closed 2 years ago

Require cargo-vendor 0.1.12 to avoid .cargo-ok churn when vendoring

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: kinetik, Assigned: xidorn)

Details

Attachments

(1 file)

During the import of bug 1403048, 'mach vendor rust' generated a huge amount of churn due to the .cargo-ok files being deleted and removed from the associated .cargo-checksum.json file.

This seems to have been caused by a change in cargo-vendor 0.1.12 (https://github.com/alexcrichton/cargo-vendor/commit/aa0267a3dd8439b914e6173a7713799ea7790b75) that excludes these files from the vendored source directory.

We should probably make cargo-vendor 0.1.12 the minimum version for 'mach vendor rust' to avoid additional cycles of add/remove churn of these files.
When I do the import of bug 1404678, I noticed the same issue. I think we should bump the requirement.
Note that, if we do this, we may want to uplift it and do revendor in beta as well, otherwise it could make uplifting some patches involving revendoring more confusing.

Also given that cargo-vendor changes its behavior every now and then, which can cause the result to fluctuate, we probably want to ping a specific version of cargo-vendor somehow, rather than relying on whatever version happens to be installed in the system.
I mean, pin a specific version.
Comment on attachment 8914048 [details]
Bug 1403407 - Require cargo-vendor 0.1.12 to remove .cargo-ok.

https://reviewboard.mozilla.org/r/185428/#review197290
Attachment #8914048 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94a7d2b657c6
Require cargo-vendor 0.1.12 to remove .cargo-ok. r=gps
This would also need vcs-sync to upgrade its cargo-vendor, I think.
ni? glob for comment 7.
Flags: needinfo?(glob)
thanks xidorn; i've manually reinstalled cargo-vendor, now running v0.1.12
Flags: needinfo?(glob)
https://hg.mozilla.org/mozilla-central/rev/94a7d2b657c6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
Assignee: nobody → xidorn+moz
You need to log in before you can comment on or make changes to this bug.