1403430 - Devirtualize nsIAtom

Status: RESOLVED INVALID

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

I've totally messed up MozReview in bug 1400459, so I'm going to try opening another bug to land this.

https://github.com/servo/servo/pull/18649 is the Servo-side PR.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1403430 - Devirtualize nsIAtom. .

This patch merges nsAtom into nsIAtom. For the moment, both names can be used
interchangeably due to a typedef. The patch also devirtualizes nsIAtom, by
making it not inherit from nsISupports, removing NS_DECL_NSIATOM, and dropping
the use of NS_IMETHOD_. It also removes nsIAtom's IIDs.

These changes trigger knock-on changes throughout the codebase, changing the
types of lots of things as follows.

- nsCOMPtr<nsIAtom> --> RefPtr<nsIAtom>

- nsCOMArray<nsIAtom> --> nsTArray<RefPtr<nsIAtom>>
  - Count() --> Length()
  - ObjectAt() --> ElementAt()
  - AppendObject() --> AppendElement()
  - RemoveObjectAt() --> RemoveElementAt()

- ns*Hashtable<nsISupportsHashKey, ...> -->
  ns*Hashtable<nsRefPtrHashKey<nsIAtom>, ...>

- nsInterfaceHashtable<T, nsIAtom> --> nsRefPtrHashtable<T, nsIAtom>
  - This requires adding a Get() method to nsRefPtrHashtable that it lacks but
    nsInterfaceHashtable has.

- nsCOMPtr<nsIMutableArray> --> nsTArray<RefPtr<nsIAtom>>
  - nsArrayBase::Create() --> nsTArray()
  - GetLength() --> Length()
  - do_QueryElementAt() --> operator[]

Review commit: https://reviewboard.mozilla.org/r/183832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183832/

Comment 2

[Nicholas Nethercote [inactive]]

Actually, it's not messed up.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8912520 [details]
Bug 1403430 - Devirtualize nsIAtom. .

https://reviewboard.mozilla.org/r/183832/#review189040