Closed
Bug 1403439
Opened 7 years ago
Closed 7 years ago
Black rectangles appear on Windows
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Whiteboard: [wr-mvp])
Attachments
(1 file)
|
1.80 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
On latest m-c, black rectangles appear on Windows when WebRender is enabled. It did not happen when native OpenGL was used.
|
Assignee | |
Comment 1•7 years ago
|
||
ANGLE failed to bind Texture because of target type mismatch. From investigation, it was caused by Bug 1383786. I should notice the problem during reviewing :(
|
|
Assignee | |
Comment 2•7 years ago
|
||
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 3•7 years ago
|
||
attachment 8912533 [details] [diff] [review] revert the accidental change by https://hg.mozilla.org/mozilla-central/rev/a7da103dab00
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6ae2c46c678e400b6936fe6489f6ca4a3871a71
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8912533 -
Flags: review?(nical.bugzilla)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8912533 [details] [diff] [review] patch - Fix WrExternalImageBufferType of DXGITextureHostD3D11 Review of attachment 8912533 [details] [diff] [review]: ----------------------------------------------------------------- Woops!
Attachment #8912533 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2aabd2eaef61 Fix WrExternalImageBufferType of DXGITextureHostD3D11 r=nical
|
||
Updated•7 years ago
|
Whiteboard: [wr-mvp] [triage]
|
||
Updated•7 years ago
|
Blocks: stage-wr-nightly
status-firefox57:
--- → unaffected
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2aabd2eaef61
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 9•7 years ago
|
||
¡Hola Sotaro! Is this truly fixed? I can still reproduce on with gfx.webrender.enabled;true on Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20171011220113 ¡Gracias! Alex
Status: RESOLVED → REOPENED
Flags: needinfo?(sotaro.ikeda.g)
Resolution: FIXED → ---
|
||
Comment 10•7 years ago
|
||
Please file a new bug instead of reopening bugs which have patches landed.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 11•7 years ago
|
||
¡Hola Kartikaya! Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1407998 FWIW. ¡Gracias! Alex
|
|
Assignee | |
Comment 12•7 years ago
|
||
(In reply to alex_mayorga from comment #9) > ¡Hola Sotaro! > > Is this truly fixed? > It was fixed and new regression was caused by ANGLE update. It was Bug 1407748. It causes black rectangle on windows.
Flags: needinfo?(sotaro.ikeda.g)
You need to log in
before you can comment on or make changes to this bug.
Description
•