Closed Bug 1403452 Opened 2 years ago Closed 2 years ago

MIgrate browser_webconsole_allow_mixedcontent_securityerrors.js to the new frontend

Categories

(DevTools :: Console, enhancement, P3)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Priority: -- → P3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8926779 [details]
Bug 1403452 - Enable browser_webconsole_block_mixedcontent_securityerrors in new console frontend; .

https://reviewboard.mozilla.org/r/198018/#review203304

Looks good, just want to make sure the skip-if change is expected.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
(Diff revision 2)
>  subsuite = clipboard
>  [browser_netmonitor_shows_reqs_in_webconsole.js]
>  [browser_webconsole_allow_mixedcontent_securityerrors.js]
>  tags = mcb
> -skip-if = true #	Bug 1403452
> -# old console skip-if = (os == 'win' && bits == 64) # Bug 1390001

I assume you checked that the old skip-if was no longer needed. Try run link? 
We should probably close Bug 1390001 after this lands then.

::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:9
(Diff revision 2)
>   * http://creativecommons.org/publicdomain/zero/1.0/ */
>  /* import-globals-from ../../../../framework/test/shared-head.js */
> -/* exported WCUL10n, openNewTabAndConsole, waitForMessages, waitForMessage, waitFor,
> -   findMessage, openContextMenu, hideContextMenu, loadDocument, hasFocus,
> +/* exported WCUL10n, DOCS_GA_PARAMS, openNewTabAndConsole, waitForMessages, waitForMessage,
> +   waitFor, findMessage, openContextMenu, hideContextMenu, loadDocument, hasFocus,
>     waitForNodeMutation, testOpenInDebugger, checkClickOnNode, jstermSetValueAndComplete,
> -   openDebugger, openConsole */
> +   openDebugger, openConsole, simulateLinkClick */

For the record you could use 

/* eslint no-unused-vars: [2, {"vars": "local"}] */

instead of listing every export here. The local setting makes it "check only that locally-declared variables are used but will allow global variables to be unused."
Attachment #8926779 - Flags: review?(jdescottes) → review+
Comment on attachment 8926779 [details]
Bug 1403452 - Enable browser_webconsole_block_mixedcontent_securityerrors in new console frontend; .

https://reviewboard.mozilla.org/r/198018/#review203304

> I assume you checked that the old skip-if was no longer needed. Try run link? 
> We should probably close Bug 1390001 after this lands then.

Yes, I wanted to see if we could get rid of it.
TRY is here https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c2c8f318d11

Bug 1390001 http://searchfox.org/mozilla-central/search?q=1390001&case=false&regexp=false&path= is used for many tests, including old ones. I'll add a comment to say we can close it when we remove all the old test, and the new ones don't need the skip-if.

> For the record you could use 
> 
> /* eslint no-unused-vars: [2, {"vars": "local"}] */
> 
> instead of listing every export here. The local setting makes it "check only that locally-declared variables are used but will allow global variables to be unused."

Oh nice, let me try that
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dac33fd437c
Enable browser_webconsole_block_mixedcontent_securityerrors in new console frontend; r=jdescottes.
https://hg.mozilla.org/mozilla-central/rev/3dac33fd437c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.