1403457 - Intermittent bugs/579323-1.html == bugs/579323-1-ref.html | image comparison, max difference: 255, number of differing pixels: 10200

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=133503344&repo=autoland

https://queue.taskcluster.net/v1/task/Ry1sT61ZQrCP92qQ0Wtgzw/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Ry1sT61ZQrCP92qQ0Wtgzw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This permafails since on Quantumrender (both opt and debug) since these merges:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=792d4db07bef813d32b03ccdbc508174637767a2&filter-searchStr=quantumrender+reftest
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=17b17a40b14a376b5509b759b2de11d7d3456846&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&filter-searchStr=quantumrender+tc-r-e10s(r4)
And it didn't fail before these merges

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Ok, I'll mark it failing for now and bisect what caused it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9d461081948
Mark a test as fails-if(webrender). r=me

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This is a regression from bug 1383786.

Try push with merge of 4d35361e1aec and 90fe4a380e8b: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35a6c69a8399f177e29971f73ce210adf584e04a
Try push with merge of 4d35361e1aec and 594f4ea5d802: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e98c2e5f97c024309a1594f37871b3bbbef56db

Nical, fyi. It seems your patches combined with the layers-free flip caused this perma-fail.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I don't think we need to leave this open. We have a big pile of fails-if(webrender) and skip-if(webrender) tests that I'm tracking externally in a spreadsheet, and we'll fix this as we tackle the rest of them.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c9d461081948

Comment 7

[Intermittent Failures Robot]

131 failures in 153 pushes (0.856 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 86
* mozilla-inbound: 31
* try: 13
* mozilla-central: 1

Platform breakdown:
* linux64-qr: 131

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1403457&startday=2017-09-27&endday=2017-09-27&tree=all

Comment 8

[Nicolas Silva [:nical]]

> Nical, fyi. It seems your patches combined with the layers-free flip caused this perma-fail.

That's not surprising, my patch queue from that bug most likely changed timings a bit in the way images are received from the ImageBirdge. I think that the problem is that canvas frames should not be sent to the compositor process using ImageBridge as they are done with layers-free, because it breaks frame consistency (can't know when a canvas update will show up on screen). I bet a lot of the canvas reftests are flacky at the moment.

Comment 9

[Nicolas Silva [:nical]]

I am referring to bug 1396588.

Comment 10

[Intermittent Failures Robot]

130 failures in 885 pushes (0.147 failures/push) were associated with this bug in the last 7 days. 

This is the #11 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 84
* mozilla-inbound: 21
* try: 15
* mozilla-central: 10

Platform breakdown:
* linux64-qr: 130

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1403457&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 11

[Kartikaya Gupta (email:[e-mail])]

OF shows this is down to zero now.