Rename various classes that inherit dom::IDTracker

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(5 attachments, 1 obsolete attachment)

Follow-up to the request in bug 1403345 comment 4.
Attachment #8914920 - Attachment is obsolete: true
Attachment #8914920 - Flags: review?(longsonr)
Attachment #8914959 - Flags: review?(longsonr)
Attachment #8914960 - Flags: review?(longsonr)
Attachment #8914961 - Flags: review?(longsonr)
Attachment #8914962 - Flags: review?(longsonr)
Attachment #8914963 - Flags: review?(longsonr)
Comment on attachment 8914959 [details]
Bug 1403500, part 1 - Document and do some renaming for SVGObserverUtils' SourceReference.

https://reviewboard.mozilla.org/r/186212/#review191552
Attachment #8914959 - Flags: review?(longsonr) → review+
Comment on attachment 8914960 [details]
Bug 1403500, part 2 - Document and do some renaming for SVGUseElement's SourceReference.

https://reviewboard.mozilla.org/r/186214/#review191554

::: dom/svg/SVGUseElement.h:86
(Diff revision 1)
>    URLExtraData* GetContentURLData() const { return mContentURLData; }
>  
>  protected:
> -  class SourceReference : public mozilla::dom::IDTracker {
> +  /**
> +   * Helper that provides a reference to the element with the ID that is
> +   * referenced by the 'use' element's 'href' attribuete, and that will update

correct spelling of attribute
Attachment #8914960 - Flags: review?(longsonr) → review+
Comment on attachment 8914961 [details]
Bug 1403500, part 3 - Document and do some renaming for SVGMPathElement's PathReference.

https://reviewboard.mozilla.org/r/186216/#review191558

::: dom/svg/SVGMPathElement.h:71
(Diff revision 1)
>    already_AddRefed<SVGAnimatedString> Href();
>  
>  protected:
> -  class PathReference : public mozilla::dom::IDTracker {
> +  /**
> +   * Helper that provides a reference to the 'path' element with the ID that is
> +   * referenced by the 'mpath' element's 'href' attribuete, and that will

correct spelling of attribute
Attachment #8914961 - Flags: review?(longsonr) → review+
Comment on attachment 8914962 [details]
Bug 1403500, part 4 - Document and do some renaming for SVGAnimationElement's TargetReference.

https://reviewboard.mozilla.org/r/186218/#review191560

::: dom/svg/SVGAnimationElement.h:104
(Diff revision 1)
>                          const nsAString& aHrefStr);
>    void AnimationTargetChanged();
>  
> -  class TargetReference : public mozilla::dom::IDTracker {
> +  /**
> +   * Helper that provides a reference to the element with the ID that is
> +   * referenced by the animation element's 'href' attribuete, if any, and that

correct spelling of attribute
Attachment #8914962 - Flags: review?(longsonr) → review+
Comment on attachment 8914963 [details]
Bug 1403500, part 5 - Document and do some renaming for nsSMILTimeValueSpec's TimeReferenceElement.

https://reviewboard.mozilla.org/r/186220/#review191562

::: dom/smil/nsSMILTimeValueSpec.h:96
(Diff revision 1)
> +   * If our nsSMILTimeValueSpec exists for a 'begin' or 'end' attribute with a
> +   * value that specifies a time that is relative to the animation of some
> +   * other element, it will create an instance of this class to reference and
> +   * track that other element.  For example, if the nsSMILTimeValueSpec is for
> +   * end='a.end+2s', an instance of this class will be created to track the
> +   * element associate with the element ID "a".  This class will notify the

the element associated with...
Attachment #8914963 - Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/456877e32a14
part 1 - Document and do some renaming for SVGObserverUtils' SourceReference. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/b015ad40c489
part 2 - Document and do some renaming for SVGUseElement's SourceReference. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e147b43c08c
part 3 - Document and do some renaming for SVGMPathElement's PathReference. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/24eb5afe1b98
part 4 - Document and do some renaming for SVGAnimationElement's TargetReference. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/490c3f1fd1e9
part 5 - Document and do some renaming for nsSMILTimeValueSpec's TimeReferenceElement. r=longsonr
You need to log in before you can comment on or make changes to this bug.