1403504 - Bookmarks toolbar doesn't use regular favicons

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[François Rousselet]

Attachment: Capture.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170926220106

Steps to reproduce:

Add bookmark (with a favicon) to bookmarks toolbar


Actual results:

Bookmarks toolbar doesn't seems to always use 'rel="icon"' for the favicon. For some websites, 'apple-touch-icon' are shown.
A similar issue as been fixed for tabs icons (https://bugzilla.mozilla.org/show_bug.cgi?id=1401777).

Comment 1

[Marco Bonardo [:mak]]

This is known and we don't plan to fix it for 57 since the changes are not safe enough for it.

Comment 2

[Marco Bonardo [:mak]]

this is not actually a regression of bug 1401777, it's an expected regression of bug 1352459

Comment 3

[MarkRH]

I suppose what would help this is if site developers used the same icon image but different sizes.  With some blogs, such http://eq2wire.com/ the favicon.ico is a microphone image which the tab has and the bookmark gets the apple_touch_icon.png which is the standard WordPress icon.

On most of my sites I just have a single 16x16 favicon.ico in the root directory.  Anyway, is kind of annoying.

Comment 4

[Marco Bonardo [:mak]]

it's not necessary, the browser must be able to pick the best icon for the resolution it needs.
Also just having a single 16x16 icon is wrong, because on a double-dpi monitor you want to have a 32x32 icon at least.

Comment 5

[Marco Bonardo [:mak]]

The regression where we always picked the biggest icon has been fixed in Nightly, I verified the twitter and gitlab icons are now ok.

There are still some edge cases where we don't pick a good 32px image that we'll handle in bug 1403829, but for the most part this is fixed.