1403514 - remove requirement to sign web extensions from the tree

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in talos we have webextensions as a .xpi and signed, when pointing to the source code, our _webext numbers improved a lot, I suspect we are not installing the webext from raw files.

Once we figure this out, we can have talos with a streamlined development process.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

the next step here is to test on try if we can run _webext tests without a signed copy

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a769014b4c8bca6b84a39b72a204183a6bafb10b

Comment 3

[Robert Wood [:rwood]]

Attachment: Bug 1403514 - remove requirement to sign talos web extensions;

Review commit: https://reviewboard.mozilla.org/r/212576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212576/

Comment 4

[Robert Wood [:rwood]]

As you suspected :jmaher, the talos dummy webext isn't loading... I confirmed it by opening a new browser window while tp5o_webext was running and checked about:addons as you suggested. Only the talos pageloader addon and talos powers were loaded.

Comment 5

[Robert Wood [:rwood]]

Hi Bob! Our talos 'dummy' web extension loads and works as long as we use the signed version. If we try to use the unsigned version (like in the patch above in comment 3) it doesn't load at all.

How can we run our unsigned version of our web extension? Are there some prefs we need to set first maybe? Thanks :)

This is the code where we actually install the extension:

https://searchfox.org/mozilla-central/rev/137f1b2f434346a0c3756ebfcbdbee4069e15dc8/testing/talos/talos/ffsetup.py#129

https://searchfox.org/mozilla-central/rev/137f1b2f434346a0c3756ebfcbdbee4069e15dc8/testing/mozbase/mozprofile/mozprofile/addons.py#365

Comment 6

[Bob Silverberg [:bsilverberg]]

There is a pref that can be set to allow unsigned extensions to be installed, which is `xpinstall.signatures.required`. I would start by trying setting that to false. 

I'm not sure what version of Firefox you're testing with. I don't think the above pref works on Release, but does on Nightly. Give it a try and let me know how it goes.

Comment 7

[Robert Wood [:rwood]]

Yes we are setting that already (sorry forgot about that):

https://searchfox.org/mozilla-central/rev/137f1b2f434346a0c3756ebfcbdbee4069e15dc8/testing/talos/talos/config.py#202

Comment 8

[Robert Wood [:rwood]]

Note: We are using unsigned legacy addons and they're working fine; but for some reason we can't use our web extension unsigned. We must be missing something...

Comment 9

[Bob Silverberg [:bsilverberg]]

That is odd. Is there anything in the output from the console that might shed some light on what's going wrong when the extension install is attempted?

Comment 10

[Robert Wood [:rwood]]

(In reply to Bob Silverberg [:bsilverberg] from comment #9)
> That is odd. Is there anything in the output from the console that might
> shed some light on what's going wrong when the extension install is
> attempted?

Good suggestion thanks!

I ran my local nightly build, manually set the xpi.install.signatures.required pref to False, then installed the extension manually via tools => add-ons => install from file. It just came up and asked was I sure I want to install the unverified add-on, I went ahead and it installed fine (nothing in console). Now on about:addons it shows up. Must be the way we are installing it programmatically...

Comment 11

[Bob Silverberg [:bsilverberg]]

I'm not really that familiar with the code that installs extensions. Andrew Swan on our team is probably the expert, but he's off this week. I'll bet that Rob Helmer might be able to help though. I'm going to needinfo him on the bug and hopefully he can help you figure it out.

Comment 12

[Robert Wood [:rwood]]

Thanks Bob :)

Comment 13

[Robert Wood [:rwood]]

Ahhhh nvm I figured it out,

1) I had a typo in the extension file name when running locally;
2) on my try push in comment 2 I was setting the extension for tspaint to the unsigned one however I had left out the setting for tp5o; so it was still pointing to the signed-xpi which didn't exist anymore so wasn't loading the webext.

Thanks Bob anyway for your time appreciated!

Comment 14

[Bob Silverberg [:bsilverberg]]

Glad to hear you figured it out!

Comment 15

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98a84f5d20f58acc88be6eacf3fb59b29aa177f

Comment 16

[Robert Wood [:rwood]]

Try run with existing signed talos dummy webext:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=52a885d65ee490d8a7292d76529903ae0d6eeb54

Try run (same rev) but with unsigned talos dummy webext:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98a84f5d20f58acc88be6eacf3fb59b29aa177f

Comment 17

[Robert Wood [:rwood]]

Ah, looking much better now:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=52a885d65ee4&newProject=try&newRevision=289f0549dd0fe531b2d1047c4ea066857506a801&framework=1

Comment 18

[Robert Wood [:rwood]]

Comment on attachment 8942291 [details]
Bug 1403514 - remove requirement to sign talos web extensions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212576/diff/1-2/

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8942291 [details]
Bug 1403514 - remove requirement to sign talos web extensions;

https://reviewboard.mozilla.org/r/212576/#review218852

awesome

Comment 20

[Robert Wood [:rwood]]

Comment on attachment 8942291 [details]
Bug 1403514 - remove requirement to sign talos web extensions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212576/diff/2-3/

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b70ab4f919ac
remove requirement to sign talos web extensions; r=jmaher

Comment 22

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b70ab4f919ac