1403522 - 'No Proxy For' does not work right if it contains '<local>' only

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Jiawei Wang]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

In configuration, set the 'No Proxy For' as '<local>', then access http://example/


Actual results:

It's accessed via the proxy server.


Expected results:

It should be accessed directly.

Comment 1

[Jiawei Wang]

If the 'No Proxy For' is set as '<local>, anything', http://example/ is accessed directly.

In netwerk/base/nsProtocolProxyService.cpp nsProtocolProxyService::CanUseProxy, there is a filter length check:

if (mHostFiltersArray.Length() == 0)
    return true;

and a plain hostname check:

// Don't use proxy for local hosts (plain hostname, no dots)
if ((!is_ipaddr && mFilterLocalHosts && !host.Contains('.')) ||
    host.EqualsLiteral("127.0.0.1") ||
    host.EqualsLiteral("::1")) {
    LOG(("Not using proxy for this local host [%s]!\n", host.get()));
    return false; // don't allow proxying
}

I think the plain hostname check should be done before the filter length check.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1403522 - 'No Proxy For' does not work right if it contains '<local>' only

Review commit: https://reviewboard.mozilla.org/r/190680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190680/

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8919739 [details]
Bug 1403522 - 'No Proxy For' does not work right if it contains '<local>' only

https://reviewboard.mozilla.org/r/190680/#review197196

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f5c0b1eff85
'No Proxy For' does not work right if it contains '<local>' only r=bagder

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4f5c0b1eff85