Add third-party URL Classifier sources to ThirdPartyPaths.txt

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: janx, Assigned: janx)

Tracking

47 Branch
mozilla58

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
As indicated in bug 1351147 comment 51, some files in /toolkit/components/url-classifier/ are imported and/or generated form third-party sources.

We should add their paths to our /tools/rewriting/ThirdPartyPaths.txt file.
Assignee

Comment 1

2 years ago
I've also updated .clang-format-ignore accordingly (and it looks like previous ThirdPartyPaths.txt updates had not been propagated yet).
Attachment #8912644 - Flags: review?(sledru)
Attachment #8912644 - Flags: review?(bpostelnicu)
Comment on attachment 8912644 [details] [diff] [review]
Add third-party URL Classifier sources to ThirdPartyPaths.txt. r=andi, r=sylvestre

Next time, please don't mix the changes :/ 
I will accept it because it would be a waste of time otherwise
Attachment #8912644 - Flags: review?(sledru)
Attachment #8912644 - Flags: review?(bpostelnicu)
Attachment #8912644 - Flags: review+
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab04ea0c6231
Add third-party URL Classifier sources to ThirdPartyPaths.txt. r=andi, r=sylvestre
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ab04ea0c6231
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.