Closed
Bug 1403527
Opened 8 years ago
Closed 8 years ago
Add third-party URL Classifier sources to ThirdPartyPaths.txt
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: janx, Assigned: janx)
Details
Attachments
(1 file)
|
2.42 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
As indicated in bug 1351147 comment 51, some files in /toolkit/components/url-classifier/ are imported and/or generated form third-party sources.
We should add their paths to our /tools/rewriting/ThirdPartyPaths.txt file.
| Assignee | ||
Comment 1•8 years ago
|
||
I've also updated .clang-format-ignore accordingly (and it looks like previous ThirdPartyPaths.txt updates had not been propagated yet).
Attachment #8912644 -
Flags: review?(sledru)
Attachment #8912644 -
Flags: review?(bpostelnicu)
Comment 2•8 years ago
|
||
Comment on attachment 8912644 [details] [diff] [review]
Add third-party URL Classifier sources to ThirdPartyPaths.txt. r=andi, r=sylvestre
Next time, please don't mix the changes :/
I will accept it because it would be a waste of time otherwise
Attachment #8912644 -
Flags: review?(sledru)
Attachment #8912644 -
Flags: review?(bpostelnicu)
Attachment #8912644 -
Flags: review+
| Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab04ea0c6231
Add third-party URL Classifier sources to ThirdPartyPaths.txt. r=andi, r=sylvestre
Keywords: checkin-needed
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•