Closed
Bug 1403535
Opened 8 years ago
Closed 8 years ago
ensureBallast before ValueNumberer::visitControlInstruction
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
Details
Attachments
(1 file)
|
925 bytes,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
Seen in one test case which is not landed for performance reasons.
IonBuilder can generate a large sequence of basic blocks which are only composed by a single control instruction.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8912654 -
Flags: review?(tcampbell)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8912654 [details] [diff] [review]
Ionmonkey: ensureBallast before visitControlInstruction.
Review of attachment 8912654 [details] [diff] [review]:
-----------------------------------------------------------------
Good find!
Attachment #8912654 -
Flags: review?(tcampbell) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c119f9d999
Ionmonkey: ensureBallast before visitControlInstruction. r=tcampbell
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•8 years ago
|
Summary: enusreBallast before ValueNumberer::visitControlInstruction → ensureBallast before ValueNumberer::visitControlInstruction
You need to log in
before you can comment on or make changes to this bug.
Description
•