Closed
Bug 1403548
Opened 7 years ago
Closed 6 years ago
Updates for ASan reporter Nightly build
Categories
(Release Engineering :: Release Requests, defect)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: decoder, Assigned: catlee)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want)
Attachments
(7 files)
6.01 KB,
patch
|
Details | Diff | Splinter Review | |
2.16 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
58 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
jlorenzo
:
checked-in+
|
Details | Review |
59 bytes,
text/x-review-board-request
|
jlorenzo
:
checked-in+
|
Details |
58 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
jlorenzo
:
checked-in+
|
Details | Review |
1.19 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
59 bytes,
text/x-review-board-request
|
Callek
:
review+
|
Details |
As discussed during the last All Hands, we need updates for a special kind of AddressSanitizer build that we now have in TC under gecko.v2.mozilla-central.latest.firefox.linux64-asan-reporter-opt. This is for the ASan Nightly project that we started in Q3 already. We need those updates only for Linux, 64-bit, english language. I'm still working on the server-side proxy parts in parallel but we should be able to wrap this up in Q4. Chris, can you help me find someone to look at this? Thanks!
Flags: needinfo?(catlee)
Assignee | ||
Comment 1•7 years ago
|
||
We're not going to be able to spend time on this in Q4 unfortunately. However, we would be happy to give you some pointers for where to get started. Off the top of my head: - We need to change what the build identifies itself as to the update server. Perhaps changing the build platform identifier would work? - Need to add the build & update generation + signing logic to the nightly task generation. The entry point for this code is here: https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#371
Flags: needinfo?(catlee)
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Bulk change of QA Contact to :jlund, per https://bugzilla.mozilla.org/show_bug.cgi?id=1428483
QA Contact: catlee → jlund
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8946855 -
Flags: review?(bhearsum)
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8946855 [details] [diff] [review] add linux64-asan to update_platform_map Review of attachment 8946855 [details] [diff] [review]: ----------------------------------------------------------------- another option is to call these 'linux64-asan-reporter', since that's what the build actually is
Comment 6•6 years ago
|
||
Comment on attachment 8946855 [details] [diff] [review] add linux64-asan to update_platform_map Don't forget to update balrogworker checkouts!
Attachment #8946855 -
Flags: review?(bhearsum) → review+
Assignee | ||
Updated•6 years ago
|
Attachment #8946855 -
Flags: checked-in+
Assignee | ||
Comment 7•6 years ago
|
||
Testing on oak: https://www.torontopubliclibrary.ca/detail.jsp?Entt=RDMEVT312807&R=EVT312807 Looks like the builds aren't producing crash symbols, causing beetmover to fail.
Reporter | ||
Comment 8•6 years ago
|
||
(In reply to Chris AtLee [:catlee] from comment #7) > Testing on oak: > https://www.torontopubliclibrary.ca/detail.jsp?Entt=RDMEVT312807&R=EVT312807 > > Looks like the builds aren't producing crash symbols, causing beetmover to > fail. ASan builds don't use separate crash symbols and have the crash reporter disabled.
Assignee | ||
Comment 10•6 years ago
|
||
I just synced up with Julien, and he recommends using a distinct channel for updates to prevent possibly updating regular nightly users to these asan builds. I'll start updating my patches to append -asan to the update channel, and also we need to bump the limit for mar filesize signing.
Flags: needinfo?(catlee)
Assignee | ||
Comment 11•6 years ago
|
||
(In reply to Chris AtLee [:catlee] from comment #7) > Testing on oak: > https://www.torontopubliclibrary.ca/detail.jsp?Entt=RDMEVT312807&R=EVT312807 Opps, copy/paste fail. The builds are here: https://treeherder.mozilla.org/#/jobs?repo=oak&filter-searchStr=nightly Builds look like they're being produced, signed and published. However, it looks like they're conflicting with the generic linux64 builds.
Comment 12•6 years ago
|
||
Was r+'d by mtabara at https://github.com/mozilla-releng/beetmoverscript/pull/111#pullrequestreview-105806476 Landed on master at https://github.com/mozilla-releng/beetmoverscript/commit/12d94ea2b1b926bbb44f821043d74b4c4dc5a661 Released as part of beetmover 5.1.0: https://pypi.python.org/pypi/beetmoverscript/5.1.0
Attachment #8962689 -
Flags: review+
Updated•6 years ago
|
Attachment #8962689 -
Flags: checked-in+
Comment hidden (mozreview-request) |
Comment 14•6 years ago
|
||
Comment on attachment 8962690 [details] Bug 1403548 - Bump beetmoverscript a=versionbump default: https://hg.mozilla.org/build/puppet/rev/d45fb9aab12e3430834225b94046d9584fef590b production: https://hg.mozilla.org/build/puppet/rev/e788badde146628a6345e80a9beea290c0dc4129
Attachment #8962690 -
Flags: checked-in+
Comment 15•6 years ago
|
||
Was r+'d by mtabara at https://github.com/mozilla-releng/beetmoverscript/pull/113#pullrequestreview-107349895 Merged on master at: https://github.com/mozilla-releng/beetmoverscript/commit/ba6847b4db13e4b524ced8553e39724fae87d670 Released as part of beetmover 5.1.1: https://github.com/mozilla-releng/beetmoverscript/releases/tag/5.1.1 & https://pypi.python.org/pypi/beetmoverscript/5.1.1 Version bumped: * on default https://hg.mozilla.org/build/puppet/rev/9db3d0b1b8398df9a181810562341d2eb275e5cd * on production https://hg.mozilla.org/build/puppet/rev/075eb3dc983a8e70e35b58b766254414a4332065
Attachment #8964575 -
Flags: review+
Attachment #8964575 -
Flags: checked-in+
Assignee | ||
Comment 16•6 years ago
|
||
Attachment #8964623 -
Flags: review?(bhearsum)
Updated•6 years ago
|
Attachment #8964623 -
Flags: review?(bhearsum) → review+
Assignee | ||
Updated•6 years ago
|
Attachment #8964623 -
Flags: checked-in+
Assignee | ||
Comment 17•6 years ago
|
||
and with that, it looks like updates are working on the 'oak' branch. you should be able to download https://queue.taskcluster.net/v1/task/JJkERZ5YSGukhQLFjmr1Dg/runs/0/artifacts/public/build/target.tar.bz2 and have it update to the latest nightly builds on oak.
Assignee | ||
Comment 18•6 years ago
|
||
The latest builds on 'oak' have the update channel set to 'nightly-oak' instead of 'nightly-oak-asan'. This shouldn't impact testing.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → catlee
Comment hidden (mozreview-request) |
Comment 20•6 years ago
|
||
mozreview-review |
Comment on attachment 8969279 [details] Bug 1403548: Enable nightly asan reportor builds and updates https://reviewboard.mozilla.org/r/238006/#review243688 I lean toward asking you to hold off landing on central based trees until Bug 1440546 lands to avoid bitrotting that one. But overall looks good. ::: taskcluster/taskgraph/transforms/beetmover.py:149 (Diff revision 1) > ], > 'linux-devedition-nightly': _DESKTOP_UPSTREAM_ARTIFACTS_UNSIGNED_EN_US + [ > "host/bin/mar", > "host/bin/mbsdiff", > ], > + 'linux64-asan-reporter-nightly': :shudder: but I guess this is the best we can do right now. Maybe an inline comment though?
Attachment #8969279 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 21•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8969279 [details] Bug 1403548: Enable nightly asan reportor builds and updates https://reviewboard.mozilla.org/r/238006/#review243688 good call. I'll make sure to wait for that to land first :)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 23•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8969279 [details] Bug 1403548: Enable nightly asan reportor builds and updates https://reviewboard.mozilla.org/r/238006/#review243688 > :shudder: but I guess this is the best we can do right now. > > Maybe an inline comment though? fixed in a the followup commit
Comment hidden (mozreview-request) |
Comment 25•6 years ago
|
||
Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a63caceffcee Enable nightly asan reportor builds and updates r=Callek
Comment 26•6 years ago
|
||
Backed out changeset a63caceffcee (bug 1403548) for liniting failure on builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/beetmover_repackage.py. CLOSED TREE Log: [task 2018-04-25T20:51:10.853Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/beetmover_repackage.py:133:5 | continuation line missing indentation or outdented (E122) [taskcluster 2018-04-25 20:51:11.379Z] === Task Finished === [taskcluster 2018-04-25 20:51:11.380Z] Unsuccessful task run with exit code: 1 completed in 284.875 seconds https://treeherder.mozilla.org/logviewer.html#?job_id=175593482&repo=autoland&lineNumber=255 Push with the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a63caceffcee5cbf5f6a3043b70f142bbbeab12c Backout: https://hg.mozilla.org/integration/autoland/rev/2df9e20ea6c0aee71514c217c8efb95c2f90de5d
Flags: needinfo?(catlee)
Comment hidden (mozreview-request) |
Comment 28•6 years ago
|
||
Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f1909255cc9 Enable nightly asan reportor builds and updates r=Callek
Comment 29•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f1909255cc9
Comment 30•6 years ago
|
||
Pushed by asasaki@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/343c66d9abb2 filter out asan on beta+release. r=catlee
Comment 32•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/343c66d9abb2
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(catlee)
Updated•2 years ago
|
Component: Custom Release Requests → Release Requests
You need to log in
before you can comment on or make changes to this bug.
Description
•