Open Bug 1403568 Opened 4 years ago Updated 2 years ago

"Default search engine" popup dismissed on refresh

Categories

(WebExtensions :: Frontend, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: marius.santa, Unassigned)

Details

Attachments

(2 files)

[Affected versions]:
Firefox 57.0b3 (20170925150345)
Firefox 58.0a1 (20170926100259)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install https://addons-dev.allizom.org/en-US/firefox/addon/default-popup-1/.
3.Refresh the page.

[Expected Results]:
The "Default search engine" popup is collapsed in the address bar.

[Actual Results]:
- The "Default search engine" popup is marked with no and dismissed.
- See attached screenshot

Notes:
This issue also reproduces if a new tab is opened by the installation as mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1397975#c46.
What happens if you click "OK" on that dialog, does the other notification re-appear?

Andrew, do you think this is an add-ons manager bug or should we keep it in permission panels?
Flags: needinfo?(marius.santa)
Flags: needinfo?(aswan)
Attached image after clicking ok.gif
Clicking on the ok on the confirmation pop-up the default search pop-up window is not re-displayed.
Flags: needinfo?(marius.santa)
I think this is attributable to
http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/browser/modules/ExtensionsUI.jsm#355

Mike, was that deliberate or should this be set to true?
Flags: needinfo?(aswan) → needinfo?(mozilla)
Ah but this is a bug in how we use the panels, not in the panels implementation.
Component: Site Identity and Permission Panels → WebExtensions: Frontend
Product: Firefox → Toolkit
This was deliberate by me. The goal was to make the popup more transient than most of the popups (so as not to bug people).

I'm more concerned with the problem Ecosia is running into where showing a firstrun page with your add-on makes the popup go away.

I've been testing some of the parameters for PopupNotification and none of them really give the experience I want. What I want is "popup is associated with page even when you go back, but disappears if you click"

I have some other ideas around timing. I'll be submitting a patch for you to take a look at.
Flags: needinfo?(mozilla)
I don't think the behavior you describe (having the popup reappear if you navigate back in history) is something that is implemented today.  Nor do I think its a great design, but that's a separate discussion.

We ran into this exact problem with the regular install-time notifications and we settled on persistent: true and timeout: 30s, you can see the documentation of what those options mean here:
http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/toolkit/modules/PopupNotifications.jsm#358
Priority: -- → P3
Wondering if any decision has been made on this yet, I still see that the dialogue for user consent disappear if newtab - first run is opened.
At this point I've recommended putting your firstrun page in a background tab. I'm still working on a better solution.
Thanks Mike for the quick response!
Product: Toolkit → WebExtensions
Has there been any updates yet for the search settings dialogue for user consent. For the user experience we want to showcase our product but since we can't direct user to firstrun page without impacting consent dialogue it makes it hard. I am trying to find-out if there has been any proposed change in the flow.
> Has there been any updates yet for the search settings dialogue for user consent. For the user experience we want to showcase our product but since we can't direct user to firstrun page without impacting consent dialogue it makes it hard. I am trying to find-out if there has been any proposed change in the flow.

Unfortunately not. We've been working on other things. It's still on our roadmap.
Thanks!

I found a solution to this bug:
On successful install of the plugin, try polling firefox’s list of search engines: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search. to see if startpage is in the list and if it’s the default with the isDefault property on the search engine object https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search/get. Then only redirect to success page if it is (aka if the user has clicked “ok” on the “set startpage to the default search engine” popup)

I found a solution to this bug:
On successful install of the plugin, try polling firefox’s list of search engines: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search. to see if your search engine is in the list and if it’s the default with the isDefault property on the search engine object https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search/get. Then only redirect to success page if it is (aka if the user has clicked “ok” on the “set your search engine to the default search engine” popup)

(In reply to contactdanielrussell from comment #14)

I found a solution to this bug:
On successful install of the plugin, try polling firefox’s list of search engines: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search. to see if your search engine is in the list and if it’s the default with the isDefault property on the search engine object https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/search/get. Then only redirect to success page if it is (aka if the user has clicked “ok” on the “set your search engine to the default search engine” popup)

Daniel this work flow works if user opt in for add-on new search engine. But in case user has not taken any action or opt out of search engine update, currently there is no event in FF to notify add-on so that we can redirect user first run.

You need to log in before you can comment on or make changes to this bug.