1403580 - Move building the new langpack to use a flag

Status: RESOLVED WONTFIX

(Firefox Build System :: General, enhancement)

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1403580 - Move building the new langpack to use a flag.

Review commit: https://reviewboard.mozilla.org/r/184020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184020/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184020/diff/1-2/

Comment 3

[Axel Hecht [:Pike]]

I cancelled the try jobs on https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3b987db87de782d9a5abd92a0812587566e6c79, 'cause those won't trigger the builds that we actually need.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be64f34bf2e5f09dd6f2c65c499ed496df3979d3 is a good example on how to get the relevant builds run.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

https://reviewboard.mozilla.org/r/184020/#review190098

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f75cc6d6d65b -d a6d12cead25a: rebasing 423388:f75cc6d6d65b "Bug 1403580 - Move building the new langpack to use a flag. r=Pike" (tip)
merging toolkit/locales/l10n.mk
warning: conflicts while merging toolkit/locales/l10n.mk! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

https://reviewboard.mozilla.org/r/184020/#review190100

Given the history of these patches, I'll mark this as an r- and re-review after rebasing and another push-to-try.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184020/diff/2-3/

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=423bdcbcefb5bf45399a5e45011a11997f9528ae

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184020/diff/3-4/

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Actually, a better one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ead61e77d4e83710e4c3374221ca127b9b304be8

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 8912697 [details]
Bug 1403580 - Move building the new langpack to use a flag.

https://reviewboard.mozilla.org/r/184020/#review190764

After talking about this patch on IRC, let's keep the new-style langpacks separate from the old-style ones, and move wholesale once we're ready.

Testing both in parallel is hard, so let's not try to, and just keep the target doing one thing once we switch.