Closed
Bug 1403658
Opened 7 years ago
Closed 7 years ago
Add nsString overload for HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), add HTMLBodyElement::FromContentOrNull() - use those in Thunderbird
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files)
|
6.49 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.52 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Add nsString overload for HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), add HTMLBodyElement::FromContentOrNull(). These are bits that are missing and should be added for completeness. They are also needed for Thunderbird.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•7 years ago
|
||
Fairly trivial review, I hope you don't mind.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8916619 -
Flags: review?(bzbarsky)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8916619 [details] [diff] [review] M-C part: 1403658-FromContentOrNull.patch (v1) r=me
Attachment #8916619 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8916618 [details] [diff] [review] C-C part: 1403658-FromContentOrNull.patch (v1) r=me. Thank you for following up on this!
Attachment #8916618 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Hi Boris, thanks for the review. I would have followed up earlier, but I had to fight some bustage in TB caused by Necko changes. Hi Sheriff, please land the M-C part only.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/138467b4e1d2 Add nsString overload for HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), add HTMLBodyElement::FromContentOrNull(). r=bz
Keywords: checkin-needed
|
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/138467b4e1d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/9f4da17feaf2 Use nsString overload of HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), use HTMLBodyElement::FromContentOrNull(). r=bz
|
|
Assignee | |
Updated•7 years ago
|
Summary: Add nsString overload for HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), add HTMLBodyElement::FromContentOrNull() → Add nsString overload for HTMLAnchorElement::GetName() and HTMLBodyElement::GetBackground(), add HTMLBodyElement::FromContentOrNull() - use those in Thunderbird
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•