59 bytes, text/x-review-board-request
Summary: Add-on install broken → Theme install broken
Component: Add-on Manager → Theme and Visual Design
Although luckily this affects only non-whitelisted sites, although for some reason for me that included addons.mozilla.org as well until I did a reset of "xpinstall.whitelist.add".
Summary: Theme install broken → Theme install broken on non-whitelisted sites
Comment on attachment 8912868 [details] Bug 1403693 - Fix IDN conversion during theme installation. https://reviewboard.mozilla.org/r/184194/#review189502
Attachment #8912868 - Flags: review?(topwu.tw) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b72247744144 Fix IDN conversion during theme installation. r=jwu
Comment on attachment 8912868 [details] Bug 1403693 - Fix IDN conversion during theme installation. Approval Request Comment [Feature/Bug causing the regression]: Bug 1391421 [User impact if declined]: Lightweight theme installation will not work on non-whitelisted sites [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Tested locally. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: Just fixes a syntax error to use the correct function signature when doing the IDN conversion. [String changes made/needed]: no
Attachment #8912868 - Flags: approval-mozilla-beta?
Comment on attachment 8912868 [details] Bug 1403693 - Fix IDN conversion during theme installation. Fix a recent regression. Should be in 57b4
Attachment #8912868 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.