Theme install broken on non-whitelisted sites

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

57 Branch
Firefox 58
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed, firefox58 fixed)

Details

Attachments

(1 attachment)

> [JavaScript Error: "NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIIDNService.convertToDisplayIDN]" {file: "chrome://browser/content/browser.js" line: 3204}]
> _installRequest@chrome://browser/content/browser.js:3204:20
> handleEvent@chrome://browser/content/browser.js:3157:9
Summary: Add-on install broken → Theme install broken
Component: Add-on Manager → Theme and Visual Design
Although luckily this affects only non-whitelisted sites, although for some reason for me that included addons.mozilla.org as well until I did a reset of "xpinstall.whitelist.add".
Summary: Theme install broken → Theme install broken on non-whitelisted sites
Comment on attachment 8912868 [details]
Bug 1403693 - Fix IDN conversion during theme installation.

https://reviewboard.mozilla.org/r/184194/#review189502
Attachment #8912868 - Flags: review?(topwu.tw) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/b72247744144
Fix IDN conversion during theme installation. r=jwu
Comment on attachment 8912868 [details]
Bug 1403693 - Fix IDN conversion during theme installation.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1391421
[User impact if declined]: Lightweight theme installation will not work on non-whitelisted sites
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Tested locally.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just fixes a syntax error to use the correct function signature when doing the IDN conversion.
[String changes made/needed]: no
Attachment #8912868 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/b72247744144
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8912868 [details]
Bug 1403693 - Fix IDN conversion during theme installation.

Fix a recent regression.
Should be in 57b4
Attachment #8912868 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.