Closed
Bug 1403697
Opened 7 years ago
Closed 7 years ago
Stop creating clips for non-rounded background color items
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(1 file)
AppendBackgroundItemsToTop pushes a clip to the display list builder's clip state in order to clip background color items to the background-clip region. However, if there is no border-radius, it would be a lot cheaper to just restrict the background color item's bounds to the background-clip region and not push a clip. This would help webrender performance because it would cut down the number of unique clip chain instances a lot, especially on pages with lots of background color items. GMail is such a page, because it uses tables, and even if you set ab background color on the whole table row, we create a background color item for every individual table cell.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8912870 [details] Bug 1403697 - When restricting background colors to the background region, only use clips if we have rounded corners. https://reviewboard.mozilla.org/r/184198/#review189418
Attachment #8912870 -
Flags: review?(matt.woodrow) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/fbc75bbbebc1 When restricting background colors to the background region, only use clips if we have rounded corners. r=mattwoodrow
Backed out for linting issues like https://treeherder.mozilla.org/logviewer.html#?job_id=134111360&repo=autoland
Flags: needinfo?(mstange)
|
||
Comment 10•7 years ago
|
||
Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fc5981835b47 Backed out changeset fbc75bbbebc1 for wptlint issues a=backout
| Comment hidden (mozreview-request) |
|
|
||
Comment 12•7 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/59e5ec5729db When restricting background colors to the background region, only use clips if we have rounded corners. r=mattwoodrow
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/59e5ec5729db
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(mstange)
You need to log in
before you can comment on or make changes to this bug.
Description
•