1403705 - Firefox 55-58: Socks proxy not working for localhost:port settings

Status: RESOLVED INVALID

(Core :: Networking, defect)

Description

[Anthony Sabathier]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170824053622

Steps to reproduce:

1. Setup a SOCKS proxy that listens on a localhost port (My use case is ssh tunneling with PuTTY - test it in a different browser)
2. Go to proxy settings and set hostname=localhost, set the port matching the one in 1.
3. Try to access a website (example: mozilla.org) without success
4. Try again in Beta, Dev, Nightly and get the same


Actual results:

HTTPS: Secure Connection Failed
HTTP: The connection was reset


Expected results:

Access the website

Comment 1

[Anthony Sabathier]

Attachment: Screenshot of my proxy settings

Comment 2

[Anthony Sabathier]

PS: I use an add-on setting the socks via preferences/service API and it works (https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/preferences_service - https://addons.mozilla.org/fr/firefox/addon/socks-proxy).

Comment 3

[Gary Chen [:xeonchen]]

You're setting up a SOCKS proxy, not a HTTP proxy.
Please try to uncheck "use this proxy server for all protocols" and leave host names empty except the SOCKS host.

Comment 4

[Anthony Sabathier]

Hi Gary,
This fixed the issue for me but it looks like an actual UX regression. 
"Use this proxy server for all protocols" implies SOCKS to be working with the same settings.
From my understanding, the design used to test each protocol until one is working. 
A comprehensive fix would be either to change this screen or revert the design to let SOCKS proxy work after other proxy settings are failing.

Comment 5

[Gary Chen [:xeonchen]]

(In reply to Anthony Sabathier from comment #4)
> Hi Gary,
> This fixed the issue for me but it looks like an actual UX regression. 
> "Use this proxy server for all protocols" implies SOCKS to be working with
> the same settings.
> From my understanding, the design used to test each protocol until one is
> working. 
> A comprehensive fix would be either to change this screen or revert the
> design to let SOCKS proxy work after other proxy settings are failing.

I agree the wording is confusing, so I'd suggest you to open another bug for the UX.
IIRC, this design doesn't change for a very long time.

Comment 6

[yaozg]

I can confirm the reported bug with Firefox nightly on windows.
A localhost proxy is not used when the "no proxy" section is empty and you try open a http server with http://localhost:port

This regression is easy to see if you use a complete new profile and open options/general/network settings
In working builds you can see "localhost, 127.0.0.1" in the no proxy section while this field is empty in broken builds.

3:17.29 INFO: No more inbound revisions, bisection finished.
3:17.29 INFO: Last good revision: e92ff56d2be21676b447c6fbb87b4c4479539bc9
3:17.29 INFO: First bad revision: cd28688c1642889442179c459ce5e6cce9a3317e
3:17.29 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e92ff56d2be21676b447c6fbb87b4c4479539bc9&tochange=cd28688c1642889442179c459ce5e6cce9a3317e

In that range this checkin looks like the culprit:

Junior Hsu — Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher

It looks like this behavior change is wanted when I look at that checkin