Closed
Bug 1403734
Opened 7 years ago
Closed 7 years ago
Customize mode footer buttons need a 2px border radius to match button styles in design system guide
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 58
People
(Reporter: abenson, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
ritu
:
approval-mozilla-beta+
|
Details |
The buttons in the footer of customize mode have square edges. A 2px border radius needs to be applied so they match buttons in preferences.
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual] [triage]
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual] [triage] → [reserve-photon-visual]
Updated•7 years ago
|
Priority: P3 → P4
Updated•7 years ago
|
Flags: qe-verify+ → qe-verify-
QA Contact: ovidiu.boca
Assignee | ||
Updated•7 years ago
|
Blocks: photon-visual
Summary: Footer buttons need a 2px border radius to match button styles in design system guide → Customize mode fvooter buttons need a 2px border radius to match button styles in design system guide
Assignee | ||
Updated•7 years ago
|
Summary: Customize mode fvooter buttons need a 2px border radius to match button styles in design system guide → Customize mode footer buttons need a 2px border radius to match button styles in design system guide
Updated•7 years ago
|
Assignee: nobody → dharvey
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P4 → P1
Assignee | ||
Comment 1•7 years ago
|
||
I'm stealing this so it can land before beta closes down.
Assignee: dharvey → dao+bmo
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8916298 [details] Bug 1403734 - Set border radius for customize mode footer buttons. https://reviewboard.mozilla.org/r/187520/#review192650
Attachment #8916298 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/270879c4294d Set border radius for customize mode footer buttons. r=Gijs
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8916298 [details] Bug 1403734 - Set border radius for customize mode footer buttons. Approval Request Comment [Feature/Bug causing the regression]: photon polish [User impact if declined]: / [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: trivial fix [String changes made/needed]: /
Attachment #8916298 -
Flags: approval-mozilla-beta?
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/270879c4294d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
status-firefox57:
--- → affected
Comment on attachment 8916298 [details] Bug 1403734 - Set border radius for customize mode footer buttons. Photon polish, beta57+
Attachment #8916298 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 8•7 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/cdbd605ca994f0becfd8105468fdfd4233b77dbf
You need to log in
before you can comment on or make changes to this bug.
Description
•