Customize mode footer buttons need a 2px border radius to match button styles in design system guide

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: abenson, Assigned: dao)

Tracking

(Blocks 1 bug)

57 Branch
Firefox 58
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The buttons in the footer of customize mode have square edges. A 2px border radius needs to be applied so they match buttons in preferences.
Whiteboard: [photon-visual] → [photon-visual] [triage]
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual] [triage] → [reserve-photon-visual]
Priority: P3 → P4
Flags: qe-verify+ → qe-verify-
QA Contact: ovidiu.boca
(Assignee)

Updated

2 years ago
Summary: Footer buttons need a 2px border radius to match button styles in design system guide → Customize mode fvooter buttons need a 2px border radius to match button styles in design system guide
(Assignee)

Updated

2 years ago
Summary: Customize mode fvooter buttons need a 2px border radius to match button styles in design system guide → Customize mode footer buttons need a 2px border radius to match button styles in design system guide

Updated

2 years ago
See Also: → 1388181
Assignee: nobody → dharvey
Status: NEW → ASSIGNED
Priority: P4 → P1
(Assignee)

Comment 1

2 years ago
I'm stealing this so it can land before beta closes down.
Assignee: dharvey → dao+bmo
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8916298 [details]
Bug 1403734 - Set border radius for customize mode footer buttons.

https://reviewboard.mozilla.org/r/187520/#review192650
Attachment #8916298 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 4

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/270879c4294d
Set border radius for customize mode footer buttons. r=Gijs
(Assignee)

Comment 5

2 years ago
Comment on attachment 8916298 [details]
Bug 1403734 - Set border radius for customize mode footer buttons.

Approval Request Comment
[Feature/Bug causing the regression]: photon polish
[User impact if declined]: /
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /
Attachment #8916298 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/270879c4294d
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8916298 [details]
Bug 1403734 - Set border radius for customize mode footer buttons.

Photon polish, beta57+
Attachment #8916298 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.