1403795 - Remove nsIDOMHTMLButtonElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuing post-addon-deprecation XPCOM interface cleanup

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1403795 - Remove nsIDOMHTMLButtonElement;

Removes the XPCOM interface for nsIDOMHTMLButtonElement, replacing it
with binding class usage.

Review commit: https://reviewboard.mozilla.org/r/184388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184388/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8913027 [details]
Bug 1403795 - Remove nsIDOMHTMLButtonElement;

https://reviewboard.mozilla.org/r/184388/#review189992

r=me

::: dom/html/HTMLButtonElement.h:118
(Diff revision 1)
>    {
>      SetHTMLBoolAttr(nsGkAtoms::disabled, aDisabled, aError);
>    }
>    // nsGenericHTMLFormElement::GetForm is fine.
>    using nsGenericHTMLFormElement::GetForm;
> -  // XPCOM GetFormAction is fine.
> +  void GetFormAction(nsAString& aFormAction)

Actually, this GetFormAction should just go away; it's more or less dead code.  That "XPCOM GetFormAction is fine" comment is a lie; that hasn't been true since bug 1366361 was fixed.  It should really say "GetFormAction implemented in superclass" or so.

You should also be able to drop the `using nsGenericHTMLFormElementWithState::GetFormAction` bit, now that you won't be overriding it in this class.

::: dom/html/HTMLButtonElement.cpp:463
(Diff revision 1)
>  
>  bool
>  HTMLButtonElement::RestoreState(nsPresState* aState)
>  {
>    if (aState && aState->IsDisabledSet() && !aState->GetDisabled()) {
> -    SetDisabled(false);
> +    ErrorResult rv;

IgnoredErrorResult, since you do ignore it...

::: dom/html/HTMLFormElement.cpp:1652
(Diff revision 1)
>  
>      nsCOMPtr<nsIDOMHTMLInputElement> inputElement = do_QueryInterface(aOriginatingElement);
>      if (inputElement) {
>        inputElement->GetFormAction(action);
>      } else {
> -      nsCOMPtr<nsIDOMHTMLButtonElement> buttonElement = do_QueryInterface(aOriginatingElement);
> +      RefPtr<HTMLButtonElement> buttonElement = HTMLButtonElement::FromContent(aOriginatingElement);

You could probably just do:

    auto buttonElement = HTMLButtonElement::FromContent(aOriginatingElement);
  
because I don't think you need a strong ref here.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8913027 [details]
Bug 1403795 - Remove nsIDOMHTMLButtonElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184388/diff/1-2/

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ccf0a9399c9a -d 9f78e0d0d331: rebasing 423440:ccf0a9399c9a "Bug 1403795 - Remove nsIDOMHTMLButtonElement; r=bz" (tip)
merging dom/interfaces/html/moz.build
merging mobile/android/modules/FormAssistant.jsm
merging xpcom/reflect/xptinfo/ShimInterfaceInfo.cpp
warning: conflicts while merging mobile/android/modules/FormAssistant.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03d936e8aec2
Remove nsIDOMHTMLButtonElement; r=bz

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/03d936e8aec2