1403830 - [EME] Remove gmp-decryption.h and its related code.

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement)

Description

[James Cheng[:JamesCheng]]

A continuation of bug 1403804,

We are able to remove the gmp-decryption.h and its related code entirely.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1403830 - [Part1] Remove gmp-decryption.h and its related code.

Review commit: https://reviewboard.mozilla.org/r/184520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184520/

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1403830 - [Part2] Remove unnecessary code and include header using gmp-platform.h.

Review commit: https://reviewboard.mozilla.org/r/184522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184522/

Comment 3

[James Cheng[:JamesCheng]]

quote from https://bugzilla.mozilla.org/show_bug.cgi?id=1392506#c20

======================
Once we've landed these changes, you need to do a GitHub PR against https://github.com/mozilla/gmp-api so that it's the same as what's in mozilla-central.

Make sure you quote the mozilla-central revision in the PR.
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              I do not quite understand what does it mean. do you have any example that I could follow?
              Honestly, I seldom request PR, so I need to google it for knowing the process.
======================
I think I will do the steps as follow,
1. fork mozilla/gmp-api to my github.
2. clone it to local and copy/paste the mozilla/central's gmp-api folder to overwrite the mozilla/gmp-api's.
3. Ideally, the diff is caused by my change in this bug.
4. push the commit to my github and do a pull request.
5. quote the mozilla-central revision in the PR?(I don't know how to do.)
Does it sound reasonable?

Thank you so much.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to James Cheng[:JamesCheng] from comment #3)
> quote from https://bugzilla.mozilla.org/show_bug.cgi?id=1392506#c20
> 
> ======================
> Once we've landed these changes, you need to do a GitHub PR against
> https://github.com/mozilla/gmp-api so that it's the same as what's in
> mozilla-central.
> 
> Make sure you quote the mozilla-central revision in the PR.
>               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>               I do not quite understand what does it mean. do you have any
> example that I could follow?

https://github.com/mozilla/gmp-api/commit/9f160569b864da950093a4daf5e083c822b244f5

When I say "quote the m-c revision in the PR", I mean in the commit message and in the PR comments.


>               Honestly, I seldom request PR, so I need to google it for
> knowing the process.

Lots of projects use GitHub, so it will be good for you to learn how GitHub works.


> ======================
> I think I will do the steps as follow,
> 1. fork mozilla/gmp-api to my github.
> 2. clone it to local and copy/paste the mozilla/central's gmp-api folder to
> overwrite the mozilla/gmp-api's.
> 3. Ideally, the diff is caused by my change in this bug.
> 4. push the commit to my github and do a pull request.
> 5. quote the mozilla-central revision in the PR?(I don't know how to do.)
> Does it sound reasonable?

Yes,  that's roughly how GitHub PR's work. Typically you'd push your changes to a branch in your repo and PR from that. You'd not typically push to you master branch of your fork.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8913097 [details]
Bug 1403830 - [Part1] Remove gmp-decryption.h and its related code.

https://reviewboard.mozilla.org/r/184520/#review189678

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8913098 [details]
Bug 1403830 - [Part2] Remove unnecessary code and include header using gmp-platform.h.

https://reviewboard.mozilla.org/r/184522/#review189680

Comment 7

[James Cheng[:JamesCheng]]

Try looks good

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b0793c2a7b6307b1fa12c1f3900ab97fb5423a7

will do the PR request,

Thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e4757f3ec89
[Part1] Remove gmp-decryption.h and its related code. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/4659afc70a23
[Part2] Remove unnecessary code and include header using gmp-platform.h. r=cpearce

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e4757f3ec89
https://hg.mozilla.org/mozilla-central/rev/4659afc70a23

Comment 10

[James Cheng[:JamesCheng]]

I've requested a PR based on my working flow in comment 3.

I've found the change does not only contain my change, it seems the repository does not always keep up with mozilla central.

So, update to mozilla-central revision e6c32278f32c