1403832 - Replace Error.Code() with Error.ErrorName() for the debug message

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Alastor Wu [:alwu]]

The follow up bug from bug 1402206.

Use ErrorName() could better know the error detailed.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1403832 - part1 : replace Error.Code() with Error.ErrorName().

Use ErrorName() could better know the error detailed.

Review commit: https://reviewboard.mozilla.org/r/184482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184482/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1403832 - part2 : reuse ErrorName() in MediaResult::Description().

Review commit: https://reviewboard.mozilla.org/r/184484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184484/

Comment 3

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ed2e9be2b1b1664f7825f23dd0255f07b1701d2

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8913074 [details]
Bug 1403832 - part1 : replace Error.Code() with Error.ErrorName().

https://reviewboard.mozilla.org/r/184482/#review189794

::: commit-message-70158:3
(Diff revision 1)
> +Bug 1403832 - part1 : replace Error.Code() with Error.ErrorName().
> +
> +Use ErrorName() could better know the error detailed.

"Use ErrorName() as it provides more useful information for the error detail"

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8913075 [details]
Bug 1403832 - part2 : reuse ErrorName() in MediaResult::Description().

https://reviewboard.mozilla.org/r/184484/#review189796

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8913074 [details]
Bug 1403832 - part1 : replace Error.Code() with Error.ErrorName().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184482/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8913075 [details]
Bug 1403832 - part2 : reuse ErrorName() in MediaResult::Description().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184484/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89061adfacb3
part1 : replace Error.Code() with Error.ErrorName(). r=jya
https://hg.mozilla.org/integration/autoland/rev/30d8969e3ec6
part2 : reuse ErrorName() in MediaResult::Description(). r=jya

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/89061adfacb3
https://hg.mozilla.org/mozilla-central/rev/30d8969e3ec6