Closed
Bug 1403857
Opened 7 years ago
Closed 7 years ago
Dark red clear color misses fast clear optimization
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(1 file)
|
2.21 KB,
patch
|
kvark
:
review+
|
Details | Diff | Splinter Review |
We are clearing the widget's background color with a dark red (0.3, 0.0, 0.0, 1.0) color. On some GPUs (intel ones in particular), clearing with transparent black or opaque white is a lot faster than any other color because it consists in mostly flipping a single flag instead of clearing all of the bits in the framebuffer. See: https://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/gfx/webrender_bindings/src/bindings.rs#646 and https://searchfox.org/mozilla-central/source/gfx/layers/wr/WebRenderBridgeParent.cpp#554 We should clear with (0.0, 0.0, 0.0, 0.0) or (1.0, 1.0, 1.0, 1.0) at least in release mode.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nical.bugzilla
Whiteboard: [wr-mvp][triage][gfx-noted]
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8913104 [details] [diff] [review] Clear with transparent black. Review of attachment 8913104 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, assuming 0.3 didn't have any valuable semantics in there.
Attachment #8913104 -
Flags: review?(kvark) → review+
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/405cec6a92e7 Clear with transparent black to benefit from fast glClear optimization. r=kvark
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp][triage][gfx-noted] → [wr-mvp] [gfx-noted]
|
||
Updated•7 years ago
|
Blocks: stage-wr-next
status-firefox57:
--- → unaffected
|
|
||
Updated•7 years ago
|
Whiteboard: [wr-mvp] [gfx-noted] → [gfx-noted]
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/405cec6a92e7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
||
Updated•7 years ago
|
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
You need to log in
before you can comment on or make changes to this bug.
Description
•