The bookmarks toolbar dropzone icon accidentally lost it's svg properties like fill, fill-opacity. Hence it looks black on dark theme. A follow up from Bug 1394933 Comment 18
Summary: Fix svg properties for Bookmarks toolbar dropzone icon → Bookmarks toolbar dropzone icon doesn't have the right color with the Dark theme
Please check how it looks on the Latest nightly light theme. Default and dark looks okay to me. Thanks
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8913150 - Flags: review?(dao+bmo)
Comment on attachment 8913150 [details] [diff] [review] bookmarks-toolbar-dropzone-icon-fills.patch You can just set these attributes on the svg element instead of both path elements.
Comment on attachment 8913154 [details] [diff] [review] bookmarks-toolbar-dropzone-icon-fills.patch Thanks!
Attachment #8913154 - Flags: review?(dao+bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d115c631b995 Add missing fill and fill-opacity attributes to bookmarks-toolbar.svg; r=dao
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Priority: -- → P1
Comment on attachment 8913154 [details] [diff] [review] bookmarks-toolbar-dropzone-icon-fills.patch Approval Request Comment [Feature/Bug causing the regression]: bug 1394933 [User impact if declined]: wrong icon color with Dark theme [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: show the bookmarks toolbar, enter customize mode and select the Dark theme [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: just adding missing attributes in the SVG icon file [String changes made/needed]: /
Attachment #8913154 - Flags: approval-mozilla-beta?
Comment on attachment 8913154 [details] [diff] [review] bookmarks-toolbar-dropzone-icon-fills.patch Polish photon, taking it. Should be in 57b5
Attachment #8913154 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox57: affected → fixed
status-firefox56: --- → unaffected
status-firefox-esr52: --- → unaffected
I verified this issue using Nightly 58.0a1 with Build ID 20171002100134 on Windows 10 x64, Windows 7 x32, Mac OS X 10.12, Ubuntu 16.04. I will mark this as verified fixed.
status-firefox58: fixed → verified
Reproduced this issue using an affected Nightly build from 2017-09-28. This is also verified fixed on Beta 57.0b6 (20171005195903) under Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.