1403893 - toolkit crashreport mips

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[qiaopengcheng]

User Agent: Mozilla/5.0 (X11; Linux mips64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170927142759

Steps to reproduce:

The function

vector<string> DwarfCFIToModule::RegisterNames::MIPS()

within file

toolkit/crashreporter/google-breakpad/src/common/dwarf_cfi_to_module.cc



Actual results:


toolkit/crashreporter/google-breakpad/src/common/dwarf_cfi_to_module.cc


vector<string> DwarfCFIToModule::RegisterNames::MIPS()

missing  fpu register  $f1.


Expected results:

including all mips fpu register.

Comment 1

[qiaopengcheng]

Attachment: Bug-1403893-toolkit-crashreport-misses-the-fpu-register $f1

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8913186 [details] [diff] [review]
Bug-1403893-toolkit-crashreport-misses-the-fpu-register  $f1

Please select only one reviewer, no need to ask 5 people.

Comment 3

[qiaopengcheng]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> Comment on attachment 8913186 [details] [diff] [review]
> Bug-1403893-toolkit-crashreport-misses-the-fpu-register  $f1
> 
> Please select only one reviewer, no need to ask 5 people.


sorry!
Next time I'll pay attention.
Thank you!

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8913186 [details] [diff] [review]
Bug-1403893-toolkit-crashreport-misses-the-fpu-register  $f1

Review of attachment 8913186 [details] [diff] [review]:
-----------------------------------------------------------------

I would normally re-route a crash reporter review to Ted. But he's away, and this is a trivial and obvious fix for a Tier-3 platform, so r=me.

Comment 5

[(not currently active) Ted Mielczarek]

This file comes from upstream Breakpad, so it needs to be fixed there:
https://chromium.googlesource.com/breakpad/breakpad/+/master/#to-request-change-review

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:qiaopengcheng-hf, could you have a look please?

Comment 7

[qiaopengcheng]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #6)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:qiaopengcheng-hf, could you have a look please?

Because the related files are third-part component. The origin repository is not mozilla.
But I don't know how to push up to the origin repository.

Comment 8

[Gabriele Svelto [:gsvelto]]

It's a shame we haven't merged this patch yet, I will be landing this as part of our locally applied patches.

Comment 9

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1403893 - Make Breakpad print out the MIPS floating point registers correctly. r=froydnj

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b80028b6b68
Make Breakpad print out the MIPS floating point registers correctly. r=froydnj

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5b80028b6b68